Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Debian init script fails when socket not specified #647

Merged
merged 1 commit into from Dec 26, 2019
Merged

Fix Debian init script fails when socket not specified #647

merged 1 commit into from Dec 26, 2019

Conversation

PeterDaveHello
Copy link
Contributor

Set $socket to default /var/run/mysqld/mysqld.sock when it's not properly detected.

MySQL works fine with socket not set in the config file, however, mysqld --print-defaults won't print it, therefore mysqld_get_param() can not fetch the info properly.

cc #583

@PeterDaveHello
Copy link
Contributor Author

Hi @delgod @EvgeniyPatlan, would you please help review/audit this PR? Thanks a lot!

@delgod delgod requested a review from EvgeniyPatlan June 3, 2018 06:24
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2019

CLA assistant check
All committers have signed the CLA.

@EvgeniyPatlan
Copy link
Contributor

thanks for your contribution @PeterDaveHello and sorry for delay with it.
Could you please sign license agreement so we could be able to merge these changes

@PeterDaveHello
Copy link
Contributor Author

Sure, it's done, thanks!

@PeterDaveHello
Copy link
Contributor Author

BTW, if you guys will like to receive more contributions, I'd be happy to help improve the shell scripts here.

@EvgeniyPatlan EvgeniyPatlan merged commit f9a300e into percona:5.7 Dec 26, 2019
@EvgeniyPatlan
Copy link
Contributor

@PeterDaveHello thank you. It would be great!

@PeterDaveHello PeterDaveHello deleted the Debian-init-script-fails-socket-not-specified branch December 26, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants