PG-646: pg_stat_monitor hangs in pgsm_store #432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A potential lock contention could've been caused when an OOM warning was being emitted by the pgsm_store function. This could lead the pg_store_error function calling pgsm_store function and thereby trying to acquire and exclusive lock when a shared was already by the same process. This warning is now guarded by protection block.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #432 +/- ##
==========================================
- Coverage 90.70% 90.56% -0.15%
==========================================
Files 3 3
Lines 1270 1272 +2
Branches 35 35
==========================================
Hits 1152 1152
- Misses 96 98 +2
Partials 22 22 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential lock contention could've been caused when an OOM warning was being emitted by the pgsm_store function. This could lead the pg_store_error function calling pgsm_store function and thereby trying to acquire and exclusive lock when a shared was already by the same process. This warning is now guarded by protection block.