Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

PMM-9722 upgrade clickhouse version #181

Merged
merged 4 commits into from
Mar 31, 2022
Merged

Conversation

nikita-b
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #181 (c339bf6) into main (9950764) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   49.05%   49.05%           
=======================================
  Files           5        5           
  Lines         318      318           
=======================================
  Hits          156      156           
  Misses        143      143           
  Partials       19       19           
Flag Coverage Δ
runcover 49.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9950764...c339bf6. Read the comment docs.

@@ -1 +1 @@
clickhouse_version: 21.3.14.1-2
clickhouse_version: 21.3.20.1-2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with the changes but it is hard to find out if fixes for cves are in, at least changelog or commits list don't have that info.
Are you sure it is in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@denisok I had a discussion with the Clickhouse team and this version also has fix

https://kb.altinity.com/upgrade/vulnerabilities/
I'll send commit to Slack

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not upgrading to 21.8.15.7-lts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atymchuk we need only fix CVE here. Fewer changes => fewer possibilities of incompatibilities :)

@nikita-b
Copy link
Contributor Author

@denisok yep, I'll fix these places too but I think we'll need one place of truth

@nikita-b nikita-b merged commit 2e247e4 into main Mar 31, 2022
@nikita-b nikita-b deleted the PMM-9722-upgrade-clickhouse branch March 31, 2022 09:56
JiriCtvrtka pushed a commit that referenced this pull request Apr 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants