-
Notifications
You must be signed in to change notification settings - Fork 9
Conversation
Codecov Report
@@ Coverage Diff @@
## main #181 +/- ##
=======================================
Coverage 49.05% 49.05%
=======================================
Files 5 5
Lines 318 318
=======================================
Hits 156 156
Misses 143 143
Partials 19 19
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
@@ -1 +1 @@ | |||
clickhouse_version: 21.3.14.1-2 | |||
clickhouse_version: 21.3.20.1-2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with the changes but it is hard to find out if fixes for cves are in, at least changelog or commits list don't have that info.
Are you sure it is in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@denisok I had a discussion with the Clickhouse team and this version also has fix
https://kb.altinity.com/upgrade/vulnerabilities/
I'll send commit to Slack
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not upgrading to 21.8.15.7-lts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@atymchuk we need only fix CVE here. Fewer changes => fewer possibilities of incompatibilities :)
couple of other places where we mention clickhouse versions or images: |
@denisok yep, I'll fix these places too but I think we'll need one place of truth |
No description provided.