Skip to content

Commit

Permalink
Tune golangci parameters, disable cache (#1279)
Browse files Browse the repository at this point in the history
* Tune golangci parameters, disable cache

* Trigger linter

* Trigger linter warn

* Revert "Trigger linter warn"

This reverts commit eaee1b7.

* Trigger linter warn

* Revert "Trigger linter warn"

This reverts commit 800f37a.
  • Loading branch information
artemgavrilov committed Oct 3, 2022
1 parent 28c6d0b commit 49a4a13
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
7 changes: 5 additions & 2 deletions .github/workflows/common.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,8 @@ jobs:
go_version: ${{ env.GO_VERSION }}
reporter: github-pr-review
fail_on_error: true
golangci_lint_flags: "-c=.golangci-required.yml --out-format=line-number"
cache: false
golangci_lint_flags: "-c=.golangci-required.yml"
golangci_lint_version: v1.49.0

- name: Run go-consistent
Expand All @@ -113,7 +114,9 @@ jobs:
github_token: ${{ secrets.ROBOT_TOKEN || secrets.GITHUB_TOKEN }}
go_version: ${{ env.GO_VERSION }}
reporter: github-pr-review
golangci_lint_flags: "-c=.golangci.yml --out-format=line-number --issues-exit-code=0"
fail_on_error: false
cache: false
golangci_lint_flags: "-c=.golangci.yml"
golangci_lint_version: v1.49.0

- name: Test common API
Expand Down
2 changes: 1 addition & 1 deletion managed/models/channel_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ func FindChannelsByIDs(q *reform.Querier, ids []string) ([]*Channel, error) {
}

p := strings.Join(q.Placeholders(1, len(ids)), ", ")
tail := fmt.Sprintf("WHERE id IN (%s) ORDER BY id", p) //nolint:gosec
tail := fmt.Sprintf("WHERE id IN (%s) ORDER BY id", p)
args := make([]interface{}, len(ids))
for i, id := range ids {
args[i] = id
Expand Down

0 comments on commit 49a4a13

Please sign in to comment.