PMM-2852 Comments in QAN filter. #1849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1849 +/- ##
==========================================
+ Coverage 42.93% 42.95% +0.01%
==========================================
Files 385 386 +1
Lines 47708 47994 +286
==========================================
+ Hits 20485 20616 +131
- Misses 25328 25451 +123
- Partials 1895 1927 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
This reverts commit afeb55c.
BupycHuk
reviewed
Jun 9, 2023
BupycHuk
approved these changes
Jun 9, 2023
| @@ -363,7 +363,8 @@ func (m *PerfSchema) getNewBuckets(periodStart time.Time, periodLengthSecs uint3 | |||
| if err != nil { | |||
| m.l.Infof("cannot parse comments from query: %s", *esh.SQLText) | |||
| } | |||
| b.Common.Comments = append(comments, queryTag) | |||
| comments["agent"] = "perfschema" | |||
There was a problem hiding this comment.
let's remove here and in other places
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-2852
Link to the Feature Build: Percona-Lab/pmm-submodules#3235
If this PR adds or removes or alters one or more API endpoints, please review and add or update the relevant API documents as well:
If this PR is related to some other PRs in this or other repositories, please provide links to those PRs: