PMM-13120 Reflect correct mode in RemoveNode. #2996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v3 #2996 +/- ##
==========================================
- Coverage 44.42% 44.38% -0.04%
==========================================
Files 368 368
Lines 35556 35277 -279
==========================================
- Hits 15794 15659 -135
+ Misses 18139 18004 -135
+ Partials 1623 1614 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
To have correct behaviour Unregister endpoint now reflect remove mode instead static models.RemoveCascade. |
JiriCtvrtka
requested review from
BupycHuk,
idoqo and
ademidoff
and removed request for
a team
BupycHuk
approved these changes
May 20, 2024
ademidoff
approved these changes
May 20, 2024
idoqo
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-13120
percona/grafana#751