PMM-12899 Use go mod cache in actions #3026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v3 #3026 +/- ##
==========================================
- Coverage 44.63% 44.58% -0.06%
==========================================
Files 368 368
Lines 35397 35397
==========================================
- Hits 15801 15781 -20
- Misses 17971 17988 +17
- Partials 1625 1628 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ademidoff
requested review from
BupycHuk,
idoqo and
JiriCtvrtka
and removed request for
a team
idoqo
approved these changes
Jun 14, 2024
| @@ -22,6 +22,13 @@ PMM_LD_FLAGS = -ldflags " \ | |||
| -X 'github.com/percona/pmm/version.Branch=$(PMM_RELEASE_BRANCH)' \ | |||
| " | |||
|
|
|||
| IS_ARM := $(filter arm64,$(shell uname -m)) | |||
There was a problem hiding this comment.
Maybe we should include aarch64 in the filter list too?
There was a problem hiding this comment.
Good idea!
Do you know what type of hardware we could get it from? I've checked my M2 processor and only got arm64.
There was a problem hiding this comment.
I think it must be RaspberryPi, right? In such case I doubt it's a good idea to run PMM Server on a Pi machine, it'd not have sufficient resources to be performant.
JiriCtvrtka
approved these changes
Jun 18, 2024
BupycHuk
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-12899
Please check the motivation for using a docker image to persist cache before reviewing.