PMM-8646 postgres_exporter on stalled after intermittent connection latency. #48

JiriCtvrtka · 2021-09-09T09:15:05Z

Our exporter merged with upstream one. Remains fix many lint errors to pass build and then test new functionality.

PMM-2705: Add security code. Rebrand exporter.

Test with all PostgreSQL versions README claims are supported.

…ds-for-PostgreSQL PMM-3436 investigate some dashboards for PostgreSQL

# Conflicts: # .travis.yml # Makefile # README.md # cmd/postgres_exporter/pg_setting.go # cmd/postgres_exporter/postgres_exporter.go # cmd/postgres_exporter/postgres_exporter_integration_test.go

PMM-3905 Port upstream changes.

PMM-3154 adding example

- Added Go 1.13.x - Made it skip non-trunk PMM-XXXX branch builds, but still build pull requests.

PMM-5192 Remove go1.12 from .travis.yml

* PMM-5723 Reviewdog checks. * PMM-5723 Add golangci config. * PMM-5723 Reviewdog required rules. * PMM-5723 Github token for reviewdog. * PMM-5723 Fix tests. Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>

PMM-6120 Use go 1.14

PMM-6213 Remove go 1.13 from travis.

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci-lint

cmd/postgres_exporter/main.go|62| line is 196 characters (lll)
cmd/postgres_exporter/main.go|63| line is 194 characters (lll)
cmd/postgres_exporter/namespace.go|106| line is 149 characters (lll)
cmd/postgres_exporter/namespace.go|112| line is 142 characters (lll)
cmd/postgres_exporter/namespace.go|117| line is 155 characters (lll)
cmd/postgres_exporter/namespace.go|135| line is 173 characters (lll)
cmd/postgres_exporter/namespace.go|141| line is 141 characters (lll)
cmd/postgres_exporter/namespace.go|146| line is 175 characters (lll)
cmd/postgres_exporter/namespace.go|158| line is 166 characters (lll)
cmd/postgres_exporter/namespace.go|173| line is 155 characters (lll)
cmd/postgres_exporter/namespace.go|96 col 4| if ok is deeply nested (complexity: 23) (nestif)
cmd/postgres_exporter/datasource.go|98 col 2| if len(dsn) == 0 is deeply nested (complexity: 12) (nestif)
cmd/postgres_exporter/queries.go|255 col 75| addQueries - result 0 (error) is always nil (unparam)
cmd/postgres_exporter/datasource.go|38 col 3| only one cuddle assignment allowed before if statement (wsl)
cmd/postgres_exporter/datasource.go|49 col 3| if statements should only be cuddled with assignments (wsl)
cmd/postgres_exporter/datasource.go|57 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/postgres_exporter/datasource.go|53 col 3| only one cuddle assignment allowed before range statement (wsl)
cmd/postgres_exporter/datasource.go|29 col 2| ranges should only be cuddled with assignments used in the iteration (wsl)
cmd/postgres_exporter/datasource.go|64 col 2| only one cuddle assignment allowed before range statement (wsl)
cmd/postgres_exporter/datasource.go|100 col 3| declarations should never be cuddled (wsl)
cmd/postgres_exporter/datasource.go|101 col 3| declarations should never be cuddled (wsl)
cmd/postgres_exporter/datasource.go|108 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/postgres_exporter/datasource.go|118 col 4| assignments should only be cuddled with other assignments (wsl)
cmd/postgres_exporter/datasource.go|139 col 2| return statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/namespace.go|43 col 2| declarations should never be cuddled (wsl)
cmd/postgres_exporter/namespace.go|52 col 2| if statements should only be cuddled with assignments (wsl)
cmd/postgres_exporter/namespace.go|59 col 2| only one cuddle assignment allowed before if statement (wsl)
cmd/postgres_exporter/namespace.go|71 col 2| only one cuddle assignment allowed before range statement (wsl)
cmd/postgres_exporter/namespace.go|105 col 6| only one cuddle assignment allowed before if statement (wsl)
cmd/postgres_exporter/namespace.go|121 col 6| ranges should only be cuddled with assignments used in the iteration (wsl)
cmd/postgres_exporter/namespace.go|178 col 4| append only allowed to cuddle with appended value (wsl)
cmd/postgres_exporter/namespace.go|181 col 2| return statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/queries.go|190 col 5| branch statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/queries.go|304 col 3| append only allowed to cuddle with appended value (wsl)
cmd/postgres_exporter/server.go|174 col 4| branch statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/server.go|158 col 2| for statement without condition should never be cuddled (wsl)
cmd/postgres_exporter/util.go|41 col 2| only one cuddle assignment allowed before switch statement (wsl)
cmd/postgres_exporter/util.go|72 col 1| calculated cyclomatic complexity for function dbToFloat64 is 12, max is 10 (cyclop)
cmd/postgres_exporter/util.go|110 col 1| calculated cyclomatic complexity for function dbToUint64 is 13, max is 10 (cyclop)
cmd/postgres_exporter/namespace.go|53 col 119| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
cmd/postgres_exporter/main.go|140 col 48| PidFn, Namespace, ReportErrors are missing in ProcessCollectorOpts (exhaustivestruct)
cmd/postgres_exporter/server.go|76 col 8| runonserver, lastMapVersion, metricMap, queryOverrides, mappingMtx, cacheMtx are missing in Server (exhaustivestruct)
cmd/postgres_exporter/server.go|143 col 10| m is missing in Servers (exhaustivestruct)
cmd/postgres_exporter/main.go|29 col 5| Branch is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|32 col 5| BuildDate is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|35 col 5| Revision is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|39 col 5| Version is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|42 col 5| VersionShort is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|52 col 2| onlyDumpMaps is a global variable (gochecknoglobals)
cmd/postgres_exporter/queries.go|50 col 5| queryOverrides is a global variable (gochecknoglobals)
cmd/postgres_exporter/namespace.go|60 col 44| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving column list for: ", namespace, err))" (goerr113)
cmd/postgres_exporter/namespace.go|82 col 45| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving rows:", namespace, err))" (goerr113)
cmd/postgres_exporter/namespace.go|130 col 47| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Missing column: ", namespace, columnName+"_sum"))" (goerr113)
cmd/postgres_exporter/queries.go|302 col 16| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving rows:", err))" (goerr113)
cmd/postgres_exporter/queries.go|308 col 15| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("error retrieving rows:", err))" (goerr113)
cmd/postgres_exporter/server.go|128 col 9| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("queryNamespaceMappings returned %d errors", len(errMap))" (goerr113)
cmd/postgres_exporter/util.go|64 col 9| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("wrong ColumnUsage given : %s", s)" (goerr113)
cmd/postgres_exporter/util.go|183 col 15| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("malformed dsn %q", dsn)" (goerr113)
cmd/postgres_exporter/util.go|182 col 23| mnd: Magic number: 2, in detected (gomnd)
cmd/postgres_exporter/queries.go|258 col 3| error is not nil (line 256) but it returns nil (nilerr)
cmd/postgres_exporter/datasource.go|33 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|40 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|51 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/main.go|99 col 3| return with no blank line before (nlreturn)
cmd/postgres_exporter/namespace.go|48 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/namespace.go|50 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/queries.go|31 col 25| yaml(camel): got 'cache_seconds' want 'cacheSeconds' (tagliatelle)
cmd/postgres_exporter/queries.go|207 col 20| error returned from external package is unwrapped: sig: func gopkg.in/yaml.v2.Unmarshal(in []byte, out interface{}) (err error) (wrapcheck)
cmd/postgres_exporter/server.go|69 col 15| error returned from external package is unwrapped: sig: func database/sql.Open(driverName string, dataSourceName string) (*database/sql.DB, error) (wrapcheck)
cmd/postgres_exporter/server.go|94 col 9| error returned from external package is unwrapped: sig: func (*database/sql.DB).Close() error (wrapcheck)
cmd/postgres_exporter/queries.go|26 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)
cmd/postgres_exporter/queries.go|36 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)

cmd/postgres_exporter/main.go

github-actions · 2021-09-17T09:10:55Z

cmd/postgres_exporter/main.go

+	disableDefaultMetrics         = kingpin.Flag("disable-default-metrics", "Do not include default metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_DEFAULT_METRICS").Bool()
+	disableSettingsMetrics        = kingpin.Flag("disable-settings-metrics", "Do not include pg_settings metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_SETTINGS_METRICS").Bool()
+	autoDiscoverDatabases         = kingpin.Flag("auto-discover-databases", "Whether to discover the databases on a server dynamically.").Default("false").Envar("PG_EXPORTER_AUTO_DISCOVER_DATABASES").Bool()
+	queriesPath                   = kingpin.Flag("extend.query-path", "Path to custom queries to run.").Default("").Envar("PG_EXPORTER_EXTEND_QUERY_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
queriesPath is unused (deadcode)

cmd/postgres_exporter/main.go

github-actions · 2021-09-17T09:10:55Z

cmd/postgres_exporter/main.go

+	constantLabelsList            = kingpin.Flag("constantLabels", "A list of label=value separated by comma(,).").Default("").Envar("PG_EXPORTER_CONSTANT_LABELS").String()
+	excludeDatabases              = kingpin.Flag("exclude-databases", "A list of databases to remove when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_EXCLUDE_DATABASES").String()
+	includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()
+	metricPrefix                  = kingpin.Flag("metric-prefix", "A metric prefix can be used to have non-default (not \"pg\") prefixes for each of the metrics").Default("pg").Envar("PG_EXPORTER_METRIC_PREFIX").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
metricPrefix is unused (deadcode)

cmd/postgres_exporter/main.go

github-actions · 2021-09-17T09:10:58Z

cmd/postgres_exporter/main.go

+	includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()
+	metricPrefix                  = kingpin.Flag("metric-prefix", "A metric prefix can be used to have non-default (not \"pg\") prefixes for each of the metrics").Default("pg").Envar("PG_EXPORTER_METRIC_PREFIX").String()
+	logger                        = log.NewNopLogger()
+	collectCustomQueryLr          = kingpin.Flag("collect.custom_query.lr", "Enable custom queries with low resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_LR").Bool()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 192 characters (lll)

github-actions · 2021-09-17T09:10:58Z

cmd/postgres_exporter/main.go

+	metricPrefix                  = kingpin.Flag("metric-prefix", "A metric prefix can be used to have non-default (not \"pg\") prefixes for each of the metrics").Default("pg").Envar("PG_EXPORTER_METRIC_PREFIX").String()
+	logger                        = log.NewNopLogger()
+	collectCustomQueryLr          = kingpin.Flag("collect.custom_query.lr", "Enable custom queries with low resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_LR").Bool()
+	collectCustomQueryMr          = kingpin.Flag("collect.custom_query.mr", "Enable custom queries with medium resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_MR").Bool()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 195 characters (lll)

github-actions · 2021-09-17T09:10:58Z

cmd/postgres_exporter/main.go

+	logger                        = log.NewNopLogger()
+	collectCustomQueryLr          = kingpin.Flag("collect.custom_query.lr", "Enable custom queries with low resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_LR").Bool()
+	collectCustomQueryMr          = kingpin.Flag("collect.custom_query.mr", "Enable custom queries with medium resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_MR").Bool()
+	collectCustomQueryHr          = kingpin.Flag("collect.custom_query.hr", "Enable custom queries with high resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_HR").Bool()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 193 characters (lll)

github-actions · 2021-09-17T09:10:58Z

cmd/postgres_exporter/main.go

+	collectCustomQueryLr          = kingpin.Flag("collect.custom_query.lr", "Enable custom queries with low resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_LR").Bool()
+	collectCustomQueryMr          = kingpin.Flag("collect.custom_query.mr", "Enable custom queries with medium resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_MR").Bool()
+	collectCustomQueryHr          = kingpin.Flag("collect.custom_query.hr", "Enable custom queries with high resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_HR").Bool()
+	collectCustomQueryLrDirectory = kingpin.Flag("collect.custom_query.lr.directory", "Path to custom queries with low resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_LR_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 193 characters (lll)

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci-lint

cmd/postgres_exporter/namespace.go|178 col 4| append only allowed to cuddle with appended value (wsl)
cmd/postgres_exporter/namespace.go|181 col 2| return statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/queries.go|190 col 5| branch statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/queries.go|304 col 3| append only allowed to cuddle with appended value (wsl)
cmd/postgres_exporter/server.go|174 col 4| branch statements should not be cuddled if block has more than two lines (wsl)
cmd/postgres_exporter/server.go|158 col 2| for statement without condition should never be cuddled (wsl)
cmd/postgres_exporter/util.go|41 col 2| only one cuddle assignment allowed before switch statement (wsl)
cmd/postgres_exporter/util.go|72 col 1| calculated cyclomatic complexity for function dbToFloat64 is 12, max is 10 (cyclop)
cmd/postgres_exporter/util.go|110 col 1| calculated cyclomatic complexity for function dbToUint64 is 13, max is 10 (cyclop)
cmd/postgres_exporter/namespace.go|53 col 119| non-wrapping format verb for fmt.Errorf. Use %w to format errors (errorlint)
cmd/postgres_exporter/main.go|140 col 48| PidFn, Namespace, ReportErrors are missing in ProcessCollectorOpts (exhaustivestruct)
cmd/postgres_exporter/server.go|76 col 8| runonserver, lastMapVersion, metricMap, queryOverrides, mappingMtx, cacheMtx are missing in Server (exhaustivestruct)
cmd/postgres_exporter/server.go|143 col 10| m is missing in Servers (exhaustivestruct)
cmd/postgres_exporter/main.go|29 col 5| Branch is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|32 col 5| BuildDate is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|35 col 5| Revision is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|39 col 5| Version is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|42 col 5| VersionShort is a global variable (gochecknoglobals)
cmd/postgres_exporter/main.go|52 col 2| onlyDumpMaps is a global variable (gochecknoglobals)
cmd/postgres_exporter/queries.go|50 col 5| queryOverrides is a global variable (gochecknoglobals)
cmd/postgres_exporter/namespace.go|60 col 44| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving column list for: ", namespace, err))" (goerr113)
cmd/postgres_exporter/namespace.go|82 col 45| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving rows:", namespace, err))" (goerr113)
cmd/postgres_exporter/namespace.go|130 col 47| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Missing column: ", namespace, columnName+"_sum"))" (goerr113)
cmd/postgres_exporter/queries.go|302 col 16| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("Error retrieving rows:", err))" (goerr113)
cmd/postgres_exporter/queries.go|308 col 15| err113: do not define dynamic errors, use wrapped static errors instead: "errors.New(fmt.Sprintln("error retrieving rows:", err))" (goerr113)
cmd/postgres_exporter/server.go|128 col 9| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("queryNamespaceMappings returned %d errors", len(errMap))" (goerr113)
cmd/postgres_exporter/util.go|64 col 9| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("wrong ColumnUsage given : %s", s)" (goerr113)
cmd/postgres_exporter/util.go|183 col 15| err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("malformed dsn %q", dsn)" (goerr113)
cmd/postgres_exporter/util.go|182 col 23| mnd: Magic number: 2, in detected (gomnd)
cmd/postgres_exporter/queries.go|258 col 3| error is not nil (line 256) but it returns nil (nilerr)
cmd/postgres_exporter/datasource.go|33 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|40 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|51 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/main.go|99 col 3| return with no blank line before (nlreturn)
cmd/postgres_exporter/namespace.go|48 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/namespace.go|50 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/queries.go|31 col 25| yaml(camel): got 'cache_seconds' want 'cacheSeconds' (tagliatelle)
cmd/postgres_exporter/queries.go|207 col 20| error returned from external package is unwrapped: sig: func gopkg.in/yaml.v2.Unmarshal(in []byte, out interface{}) (err error) (wrapcheck)
cmd/postgres_exporter/server.go|69 col 15| error returned from external package is unwrapped: sig: func database/sql.Open(driverName string, dataSourceName string) (*database/sql.DB, error) (wrapcheck)
cmd/postgres_exporter/server.go|94 col 9| error returned from external package is unwrapped: sig: func (*database/sql.DB).Close() error (wrapcheck)
cmd/postgres_exporter/queries.go|26 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)
cmd/postgres_exporter/queries.go|36 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)

github-actions · 2021-09-17T09:11:29Z

cmd/postgres_exporter/main.go

+	collectCustomQueryMr          = kingpin.Flag("collect.custom_query.mr", "Enable custom queries with medium resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_MR").Bool()
+	collectCustomQueryHr          = kingpin.Flag("collect.custom_query.hr", "Enable custom queries with high resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_HR").Bool()
+	collectCustomQueryLrDirectory = kingpin.Flag("collect.custom_query.lr.directory", "Path to custom queries with low resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_LR_PATH").String()
+	collectCustomQueryMrDirectory = kingpin.Flag("collect.custom_query.mr.directory", "Path to custom queries with medium resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_MR_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 196 characters (lll)

github-actions · 2021-09-17T09:11:29Z

cmd/postgres_exporter/main.go

+	collectCustomQueryHr          = kingpin.Flag("collect.custom_query.hr", "Enable custom queries with high resolution directory.").Default("false").Envar("PG_EXPORTER_EXTEND_QUERY_HR").Bool()
+	collectCustomQueryLrDirectory = kingpin.Flag("collect.custom_query.lr.directory", "Path to custom queries with low resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_LR_PATH").String()
+	collectCustomQueryMrDirectory = kingpin.Flag("collect.custom_query.mr.directory", "Path to custom queries with medium resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_MR_PATH").String()
+	collectCustomQueryHrDirectory = kingpin.Flag("collect.custom_query.hr.directory", "Path to custom queries with high resolution directory.").Envar("PG_EXPORTER_EXTEND_QUERY_HR_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 194 characters (lll)

github-actions · 2021-09-17T09:11:29Z

cmd/postgres_exporter/namespace.go

+					var keys []float64
+					err = pq.Array(&keys).Scan(columnData[idx])
+					if err != nil {
+						return []prometheus.Metric{}, []error{}, errors.New(fmt.Sprintln("Error retrieving", columnName, "buckets:", namespace, err))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 149 characters (lll)

github-actions · 2021-09-17T09:11:29Z

cmd/postgres_exporter/namespace.go

+					var values []int64
+					valuesIdx, ok := columnIdx[columnName+"_bucket"]
+					if !ok {
+						nonfatalErrors = append(nonfatalErrors, errors.New(fmt.Sprintln("Missing column: ", namespace, columnName+"_bucket")))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 142 characters (lll)

github-actions · 2021-09-17T09:11:29Z

cmd/postgres_exporter/namespace.go

+					}
+					err = pq.Array(&values).Scan(columnData[valuesIdx])
+					if err != nil {
+						return []prometheus.Metric{}, []error{}, errors.New(fmt.Sprintln("Error retrieving", columnName, "bucket values:", namespace, err))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 155 characters (lll)

github-actions · 2021-09-17T09:11:31Z

cmd/postgres_exporter/namespace.go

+	} else {
+		rows, err = server.db.Query(query)
+	}
+	if err != nil {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments (wsl)

github-actions · 2021-09-17T09:11:32Z

cmd/postgres_exporter/namespace.go

+
+	var columnNames []string
+	columnNames, err = rows.Columns()
+	if err != nil {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before if statement (wsl)

github-actions · 2021-09-17T09:11:32Z

cmd/postgres_exporter/namespace.go

+
+	var columnData = make([]interface{}, len(columnNames))
+	var scanArgs = make([]interface{}, len(columnNames))
+	for i := range columnData {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before range statement (wsl)

github-actions · 2021-09-17T09:11:32Z

cmd/postgres_exporter/namespace.go

+				if metricMapping.histogram {
+					var keys []float64
+					err = pq.Array(&keys).Scan(columnData[idx])
+					if err != nil {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
only one cuddle assignment allowed before if statement (wsl)

github-actions · 2021-09-17T09:11:32Z

cmd/postgres_exporter/namespace.go

+					}
+
+					buckets := make(map[float64]uint64, len(keys))
+					for i, key := range keys {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
ranges should only be cuddled with assignments used in the iteration (wsl)

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

golangci-lint

cmd/postgres_exporter/datasource.go|33 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|40 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/datasource.go|51 col 4| continue with no blank line before (nlreturn)
cmd/postgres_exporter/main.go|99 col 3| return with no blank line before (nlreturn)
cmd/postgres_exporter/namespace.go|48 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/namespace.go|50 col 30| rows.Err must be checked (rowserrcheck)
cmd/postgres_exporter/queries.go|31 col 25| yaml(camel): got 'cache_seconds' want 'cacheSeconds' (tagliatelle)
cmd/postgres_exporter/queries.go|207 col 20| error returned from external package is unwrapped: sig: func gopkg.in/yaml.v2.Unmarshal(in []byte, out interface{}) (err error) (wrapcheck)
cmd/postgres_exporter/server.go|69 col 15| error returned from external package is unwrapped: sig: func database/sql.Open(driverName string, dataSourceName string) (*database/sql.DB, error) (wrapcheck)
cmd/postgres_exporter/server.go|94 col 9| error returned from external package is unwrapped: sig: func (*database/sql.DB).Close() error (wrapcheck)
cmd/postgres_exporter/queries.go|26 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)
cmd/postgres_exporter/queries.go|36 col 1| directive // nolint: golint is unused for linter "golint" (nolintlint)

github-actions · 2021-09-17T09:11:38Z

cmd/postgres_exporter/namespace.go

+				}
+				metric = prometheus.MustNewConstMetric(desc, prometheus.UntypedValue, value, labels...)
+			}
+			metrics = append(metrics, metric)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

github-actions · 2021-09-17T09:11:38Z

cmd/postgres_exporter/namespace.go

+			metrics = append(metrics, metric)
+		}
+	}
+	return metrics, nonfatalErrors, nil


🚫 [golangci-lint] _{reported by reviewdog 🐶}
return statements should not be cuddled if block has more than two lines (wsl)

github-actions · 2021-09-17T09:11:38Z

cmd/postgres_exporter/queries.go

+			if queryDef.versionRange(pgVersion) {
+				resultMap[name] = queryDef.query
+				matched = true
+				break


🚫 [golangci-lint] _{reported by reviewdog 🐶}
branch statements should not be cuddled if block has more than two lines (wsl)

github-actions · 2021-09-17T09:11:38Z

cmd/postgres_exporter/queries.go

+		if err != nil {
+			return nil, errors.New(fmt.Sprintln("Error retrieving rows:", err))
+		}
+		result = append(result, databaseName)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
append only allowed to cuddle with appended value (wsl)

github-actions · 2021-09-17T09:11:38Z

cmd/postgres_exporter/server.go

+		if err = server.Ping(); err != nil {
+			delete(s.servers, dsn)
+			time.Sleep(time.Duration(errCount) * time.Second)
+			continue


🚫 [golangci-lint] _{reported by reviewdog 🐶}
branch statements should not be cuddled if block has more than two lines (wsl)

github-actions · 2021-09-17T09:11:40Z

cmd/postgres_exporter/server.go

+
+	errMap := queryNamespaceMappings(ch, s)
+	if len(errMap) > 0 {
+		err = fmt.Errorf("queryNamespaceMappings returned %d errors", len(errMap))


🚫 [golangci-lint] _{reported by reviewdog 🐶}
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("queryNamespaceMappings returned %d errors", len(errMap))" (goerr113)

github-actions · 2021-09-17T09:11:40Z

cmd/postgres_exporter/util.go

+		u = DURATION
+
+	default:
+		err = fmt.Errorf("wrong ColumnUsage given : %s", s)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("wrong ColumnUsage given : %s", s)" (goerr113)

github-actions · 2021-09-17T09:11:41Z

cmd/postgres_exporter/util.go

+	for _, pair := range pairs {
+		splitted := strings.SplitN(pair, "=", 2)
+		if len(splitted) != 2 {
+			return "", fmt.Errorf("malformed dsn %q", dsn)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
err113: do not define dynamic errors, use wrapped static errors instead: "fmt.Errorf("malformed dsn %q", dsn)" (goerr113)

github-actions · 2021-09-17T09:11:41Z

cmd/postgres_exporter/util.go

+	kv := make(map[string]string, len(pairs))
+	for _, pair := range pairs {
+		splitted := strings.SplitN(pair, "=", 2)
+		if len(splitted) != 2 {


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 2, in detected (gomnd)

github-actions · 2021-09-17T09:11:41Z

cmd/postgres_exporter/queries.go

+func addQueries(content []byte, pgVersion semver.Version, server *Server) error {
+	metricMaps, newQueryOverrides, err := parseUserQueries(content)
+	if err != nil {
+		return nil


🚫 [golangci-lint] _{reported by reviewdog 🐶}
error is not nil (line 256) but it returns nil (nilerr)

This reverts commit 3a589ea.

github-actions · 2021-09-17T11:04:49Z

cmd/postgres_exporter/datasource.go

+		parsedDSN, err := url.Parse(dsn)
+		if err != nil {
+			log.Errorf("Unable to parse DSN (%s): %v", loggableDSN(dsn), err)
+			continue


🚫 [golangci-lint] _{reported by reviewdog 🐶}
continue with no blank line before (nlreturn)

github-actions · 2021-09-17T11:04:49Z

cmd/postgres_exporter/datasource.go

+		server, err := e.servers.GetServer(dsn)
+		if err != nil {
+			log.Errorf("Error opening connection to database (%s): %v", loggableDSN(dsn), err)
+			continue


🚫 [golangci-lint] _{reported by reviewdog 🐶}
continue with no blank line before (nlreturn)

github-actions · 2021-09-17T11:04:49Z

cmd/postgres_exporter/datasource.go

+		server.mappingMtx.Unlock()
+		if err != nil {
+			log.Errorf("Error querying databases (%s): %v", loggableDSN(dsn), err)
+			continue


🚫 [golangci-lint] _{reported by reviewdog 🐶}
continue with no blank line before (nlreturn)

github-actions · 2021-09-17T11:04:49Z

cmd/postgres_exporter/main.go

+
+	if *onlyDumpMaps {
+		dumpMaps()
+		return


🚫 [golangci-lint] _{reported by reviewdog 🐶}
return with no blank line before (nlreturn)

github-actions · 2021-09-17T11:04:49Z

cmd/postgres_exporter/namespace.go

+	if !found {
+		// I've no idea how to avoid this properly at the moment, but this is
+		// an admin tool so you're not injecting SQL right?
+		rows, err = server.db.Query(fmt.Sprintf("SELECT * FROM %s;", namespace)) // nolint: gas


🚫 [golangci-lint] _{reported by reviewdog 🐶}
rows.Err must be checked (rowserrcheck)

github-actions · 2021-09-17T11:04:50Z

cmd/postgres_exporter/queries.go

+
+	err := yaml.Unmarshal(content, &userQueries)
+	if err != nil {
+		return nil, nil, err


🚫 [golangci-lint] _{reported by reviewdog 🐶}
error returned from external package is unwrapped: sig: func gopkg.in/yaml.v2.Unmarshal(in []byte, out interface{}) (err error) (wrapcheck)

github-actions · 2021-09-17T11:04:50Z

cmd/postgres_exporter/server.go

+
+	db, err := sql.Open("postgres", dsn)
+	if err != nil {
+		return nil, err


🚫 [golangci-lint] _{reported by reviewdog 🐶}
error returned from external package is unwrapped: sig: func database/sql.Open(driverName string, dataSourceName string) (*database/sql.DB, error) (wrapcheck)

github-actions · 2021-09-17T11:04:50Z

cmd/postgres_exporter/server.go

+
+// Close disconnects from Postgres.
+func (s *Server) Close() error {
+	return s.db.Close()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
error returned from external package is unwrapped: sig: func (*database/sql.DB).Close() error (wrapcheck)

github-actions · 2021-09-17T11:04:50Z

cmd/postgres_exporter/queries.go

+)
+
+// UserQuery represents a user defined query
+// nolint: golint


🚫 [golangci-lint] _{reported by reviewdog 🐶}
directive // nolint: golint is unused for linter "golint" (nolintlint)

github-actions · 2021-09-17T11:04:50Z

cmd/postgres_exporter/queries.go

+}
+
+// UserQueries represents a set of UserQuery objects
+// nolint: golint


🚫 [golangci-lint] _{reported by reviewdog 🐶}
directive // nolint: golint is unused for linter "golint" (nolintlint)

github-actions · 2021-09-17T11:15:43Z

cmd/postgres_exporter/main.go

+
+var (
+	listenAddress = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").Envar("PG_EXPORTER_WEB_LISTEN_ADDRESS").String()
+	//webConfig                     = webflag.AddFlags(kingpin.CommandLine)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:43Z

cmd/postgres_exporter/main.go

+	disableDefaultMetrics  = kingpin.Flag("disable-default-metrics", "Do not include default metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_DEFAULT_METRICS").Bool()
+	disableSettingsMetrics = kingpin.Flag("disable-settings-metrics", "Do not include pg_settings metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_SETTINGS_METRICS").Bool()
+	autoDiscoverDatabases  = kingpin.Flag("auto-discover-databases", "Whether to discover the databases on a server dynamically.").Default("false").Envar("PG_EXPORTER_AUTO_DISCOVER_DATABASES").Bool()
+	//queriesPath                   = kingpin.Flag("extend.query-path", "Path to custom queries to run.").Default("").Envar("PG_EXPORTER_EXTEND_QUERY_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:44Z

cmd/postgres_exporter/main.go

+	onlyDumpMaps       = kingpin.Flag("dumpmaps", "Do not run, simply dump the maps.").Bool()
+	constantLabelsList = kingpin.Flag("constantLabels", "A list of label=value separated by comma(,).").Default("").Envar("PG_EXPORTER_CONSTANT_LABELS").String()
+	excludeDatabases   = kingpin.Flag("exclude-databases", "A list of databases to remove when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_EXCLUDE_DATABASES").String()
+	//includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:44Z

cmd/postgres_exporter/main.go

+	excludeDatabases   = kingpin.Flag("exclude-databases", "A list of databases to remove when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_EXCLUDE_DATABASES").String()
+	//includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()
+	//metricPrefix                  = kingpin.Flag("metric-prefix", "A metric prefix can be used to have non-default (not \"pg\") prefixes for each of the metrics").Default("pg").Envar("PG_EXPORTER_METRIC_PREFIX").String()
+	//logger                        = log.NewNopLogger()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

github-actions · 2021-09-17T11:15:44Z

cmd/postgres_exporter/main.go

+var VersionShort = "0.0.1"
+
+var (
+	listenAddress = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").Envar("PG_EXPORTER_WEB_LISTEN_ADDRESS").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 177 characters (lll)

github-actions · 2021-09-17T11:15:45Z

cmd/postgres_exporter/main.go

+	disableSettingsMetrics = kingpin.Flag("disable-settings-metrics", "Do not include pg_settings metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_SETTINGS_METRICS").Bool()
+	autoDiscoverDatabases  = kingpin.Flag("auto-discover-databases", "Whether to discover the databases on a server dynamically.").Default("false").Envar("PG_EXPORTER_AUTO_DISCOVER_DATABASES").Bool()
+	//queriesPath                   = kingpin.Flag("extend.query-path", "Path to custom queries to run.").Default("").Envar("PG_EXPORTER_EXTEND_QUERY_PATH").String()
+	onlyDumpMaps       = kingpin.Flag("dumpmaps", "Do not run, simply dump the maps.").Bool()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
onlyDumpMaps is a global variable (gochecknoglobals)

github-actions · 2021-09-17T11:15:45Z

cmd/postgres_exporter/util.go

+	case []byte:
+		// Try and convert to string and then parse to a float64
+		strV := string(v)
+		result, err := strconv.ParseFloat(strV, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 64, in detected (gomnd)

github-actions · 2021-09-17T11:15:45Z

cmd/postgres_exporter/util.go

+		}
+		return result, true
+	case string:
+		result, err := strconv.ParseFloat(v, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 64, in detected (gomnd)

github-actions · 2021-09-17T11:15:45Z

cmd/postgres_exporter/util.go

+	case []byte:
+		// Try and convert to string and then parse to a uint64
+		strV := string(v)
+		result, err := strconv.ParseUint(strV, 10, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 10, in detected (gomnd)

github-actions · 2021-09-17T11:15:45Z

cmd/postgres_exporter/util.go

+		}
+		return result, true
+	case string:
+		result, err := strconv.ParseUint(v, 10, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 10, in detected (gomnd)

github-actions · 2021-09-17T11:15:46Z

cmd/postgres_exporter/main.go

+
+var (
+	listenAddress = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").Envar("PG_EXPORTER_WEB_LISTEN_ADDRESS").String()
+	//webConfig                     = webflag.AddFlags(kingpin.CommandLine)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:48Z

cmd/postgres_exporter/main.go

+	disableDefaultMetrics  = kingpin.Flag("disable-default-metrics", "Do not include default metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_DEFAULT_METRICS").Bool()
+	disableSettingsMetrics = kingpin.Flag("disable-settings-metrics", "Do not include pg_settings metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_SETTINGS_METRICS").Bool()
+	autoDiscoverDatabases  = kingpin.Flag("auto-discover-databases", "Whether to discover the databases on a server dynamically.").Default("false").Envar("PG_EXPORTER_AUTO_DISCOVER_DATABASES").Bool()
+	//queriesPath                   = kingpin.Flag("extend.query-path", "Path to custom queries to run.").Default("").Envar("PG_EXPORTER_EXTEND_QUERY_PATH").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:48Z

cmd/postgres_exporter/main.go

+	onlyDumpMaps       = kingpin.Flag("dumpmaps", "Do not run, simply dump the maps.").Bool()
+	constantLabelsList = kingpin.Flag("constantLabels", "A list of label=value separated by comma(,).").Default("").Envar("PG_EXPORTER_CONSTANT_LABELS").String()
+	excludeDatabases   = kingpin.Flag("exclude-databases", "A list of databases to remove when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_EXCLUDE_DATABASES").String()
+	//includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
commentFormatting: put a space between // and comment text (gocritic)

github-actions · 2021-09-17T11:15:48Z

cmd/postgres_exporter/main.go

+	excludeDatabases   = kingpin.Flag("exclude-databases", "A list of databases to remove when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_EXCLUDE_DATABASES").String()
+	//includeDatabases              = kingpin.Flag("include-databases", "A list of databases to include when autoDiscoverDatabases is enabled").Default("").Envar("PG_EXPORTER_INCLUDE_DATABASES").String()
+	//metricPrefix                  = kingpin.Flag("metric-prefix", "A metric prefix can be used to have non-default (not \"pg\") prefixes for each of the metrics").Default("pg").Envar("PG_EXPORTER_METRIC_PREFIX").String()
+	//logger                        = log.NewNopLogger()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
Comment should end in a period (godot)

github-actions · 2021-09-17T11:15:48Z

cmd/postgres_exporter/main.go

+var VersionShort = "0.0.1"
+
+var (
+	listenAddress = kingpin.Flag("web.listen-address", "Address to listen on for web interface and telemetry.").Default(":9187").Envar("PG_EXPORTER_WEB_LISTEN_ADDRESS").String()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
line is 177 characters (lll)

github-actions · 2021-09-17T11:15:49Z

cmd/postgres_exporter/main.go

+	disableSettingsMetrics = kingpin.Flag("disable-settings-metrics", "Do not include pg_settings metrics.").Default("false").Envar("PG_EXPORTER_DISABLE_SETTINGS_METRICS").Bool()
+	autoDiscoverDatabases  = kingpin.Flag("auto-discover-databases", "Whether to discover the databases on a server dynamically.").Default("false").Envar("PG_EXPORTER_AUTO_DISCOVER_DATABASES").Bool()
+	//queriesPath                   = kingpin.Flag("extend.query-path", "Path to custom queries to run.").Default("").Envar("PG_EXPORTER_EXTEND_QUERY_PATH").String()
+	onlyDumpMaps       = kingpin.Flag("dumpmaps", "Do not run, simply dump the maps.").Bool()


🚫 [golangci-lint] _{reported by reviewdog 🐶}
onlyDumpMaps is a global variable (gochecknoglobals)

github-actions · 2021-09-17T11:15:49Z

cmd/postgres_exporter/util.go

+	case []byte:
+		// Try and convert to string and then parse to a float64
+		strV := string(v)
+		result, err := strconv.ParseFloat(strV, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 64, in detected (gomnd)

github-actions · 2021-09-17T11:15:49Z

cmd/postgres_exporter/util.go

+		}
+		return result, true
+	case string:
+		result, err := strconv.ParseFloat(v, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 64, in detected (gomnd)

github-actions · 2021-09-17T11:15:49Z

cmd/postgres_exporter/util.go

+	case []byte:
+		// Try and convert to string and then parse to a uint64
+		strV := string(v)
+		result, err := strconv.ParseUint(strV, 10, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 10, in detected (gomnd)

github-actions · 2021-09-17T11:15:49Z

cmd/postgres_exporter/util.go

+		}
+		return result, true
+	case string:
+		result, err := strconv.ParseUint(v, 10, 64)


🚫 [golangci-lint] _{reported by reviewdog 🐶}
mnd: Magic number: 10, in detected (gomnd)

arvenil and others added 30 commits July 30, 2018 21:48

PMM-2705: Add security code. Rebrand exporter.

dd21600

Merge pull request #1 from percona/PMM-2705

95392e4

PMM-2705: Add security code. Rebrand exporter.

Test with more PostgreSQL versions

4d28b98

Test with all PostgreSQL versions README claims are supported.

Typo.

c98f0f1

Merge pull request #3 from percona/typo

b2bd4c9

PMM-3091 Typo.

PMM-3353 postgres_exporter does not work with PG11

8310f24

PMM-3436 investigate some dashboards for PostgreSQL

9fb4a61

Merge pull request #6 from percona/PMM-3436-investigate-some-dashboar…

f8d27b7

…ds-for-PostgreSQL PMM-3436 investigate some dashboards for PostgreSQL

Update .travis.yml

7a7725d

Merge remote-tracking branch 'upstream/master'

763e93e

# Conflicts: # .travis.yml # Makefile # README.md # cmd/postgres_exporter/pg_setting.go # cmd/postgres_exporter/postgres_exporter.go # cmd/postgres_exporter/postgres_exporter_integration_test.go

PMM-3905 Small Dockerfile fix.

10bf562

Merge pull request #9 from percona/PMM-3905-merge-with-upstream

2694d42

PMM-3905 Port upstream changes.

PMM-4354 collect[] parameter. (#10)

bd9bf59

PMM-4354 Fix process and go collectors. (#11)

c975a80

PMM-4533 Test for SSL support. (#13)

dfbbcee

PMM-3154 adding example

4b13d42

Merge pull request #15 from percona/PMM-3154-adding-example

50d8b60

PMM-3154 adding example

PMM-4355 Add custom queries implementation with three resolution. (#12)

7cf6930

PMM-4010 Updated travis.yml

6cc1ce2

- Added Go 1.13.x - Made it skip non-trunk PMM-XXXX branch builds, but still build pull requests.

PMM-5192 Remove go1.12 from .travis.yml

8ac7f60

Merge pull request #18 from percona/PMM-5192-replace-go1.12-with-go1.13

2575eba

PMM-5192 Remove go1.12 from .travis.yml

PMM-5723 Reviewdog checks. (#20)

3107916

* PMM-5723 Reviewdog checks. * PMM-5723 Add golangci config. * PMM-5723 Reviewdog required rules. * PMM-5723 Github token for reviewdog. * PMM-5723 Fix tests. Co-authored-by: Andrii Skomorokhov <andrii.skomorokhov@percona.com>

PMM-6120 Use go 1.14

41a6c8e

Merge pull request #21 from percona/PMM-6120-use-go-v1.14

c677de1

PMM-6120 Use go 1.14

PMM-6213 Remove go 1.13 from travis.

0981112

PMM-6213 Add go 1.15.x

380ea00

PMM-6213 Add go tip.

453a0fd

Merge pull request #22 from percona/PMM-6213-remove-go-1.13

ceb4af0

PMM-6213 Remove go 1.13 from travis.

PMM-5701 DB_Uptime in Home Dashboard shows wrong metric

0cd1cb3

PMM-5701 DB_Uptime in Home Dashboard shows wrong metric

a0e5e6c

JiriCtvrtka had a problem deploying to CI September 17, 2021 09:09 Failure

JiriCtvrtka had a problem deploying to CI September 17, 2021 09:09 Error

github-actions bot reviewed Sep 17, 2021

View reviewed changes

Jiri Ctvrtka added 5 commits September 17, 2021 12:56

PMM-8646 Remove tools.

61a3b6d

PMM-8646 Tools changes.

3a589ea

Revert "PMM-8646 Tools changes."

525d4ae

This reverts commit 3a589ea.

Auto stash before revert of "PMM-8646 Tools changes."

0ff2d3a

(no branch):

931fce1

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:03 Failure

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:03 Error

github-actions bot reviewed Sep 17, 2021

View reviewed changes

PMM-8646 Test changes.

3e770e0

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:09 Failure

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:09 Error

PMM-8646 Mod.

07ecb45

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:14 Failure

JiriCtvrtka had a problem deploying to CI September 17, 2021 11:14 Error

github-actions bot reviewed Sep 17, 2021

View reviewed changes

ademidoff force-pushed the main branch from 46945ca to 3662a01 Compare September 6, 2022 10:41

JiriCtvrtka closed this Sep 6, 2022

tshcherban deleted the PMM-8646-error-after-delay branch September 6, 2022 12:06

PMM-8646 postgres_exporter on stalled after intermittent connection latency. #48

PMM-8646 postgres_exporter on stalled after intermittent connection latency. #48

Conversation

JiriCtvrtka commented Sep 9, 2021 • edited Loading

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

github-actions bot Sep 17, 2021

Choose a reason for hiding this comment

JiriCtvrtka commented Sep 9, 2021 •

edited

Loading