Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃悰 Don't include shadow root when disableShadowDOMSerialization is passed #1210

Closed
wants to merge 5 commits into from
Closed

馃悰 Don't include shadow root when disableShadowDOMSerialization is passed #1210

wants to merge 5 commits into from

Conversation

samarsault
Copy link
Contributor

@samarsault samarsault commented Mar 14, 2023 •
edited by itsjwala
Loading

  • When using chromium test browser with enable javascript, JS based shadow roots are being included in the snapshot causing double rendering (an extension of TypeError: Cannot read properties of null (reading 'cssRules')聽#1194), we'll suggest users to disable shadow dom serialization in this case.
  • As part of this PR we're also renaming the param from disableShadowDOM to disableShadowDOMSerialization

@samarsault samarsault mentioned this pull request Mar 14, 2023
Closed
@percy percy deleted a comment from samarsault Mar 20, 2023
@itsjwala itsjwala changed the title Don't include shadow root with enable JS 馃悰 Don't include shadow root when disableShadowDOMSerialization is passed Mar 20, 2023
@itsjwala
Copy link
Contributor

RUN_REGRESSION

@itsjwala
Copy link
Contributor

This is not required currently, we'll revisit this later.

@itsjwala itsjwala closed this Mar 24, 2023
@itsjwala itsjwala deleted the enable-js-shadow branch March 24, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjwala itsjwala itsjwala left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samarsault @itsjwala