This repository has been archived by the owner on Feb 13, 2022. It is now read-only.
feat: Add passthrough option
#12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a user to use the exec-action to only set the Percy env vars that are needed for things to work correctly. This also adds a few env var tests
Robdel12
force-pushed
the
rd/passthrough
branch
from
bbc8cca
to
a88543d
Compare
Robdel12
force-pushed
the
rd/passthrough
branch
from
a88543d
to
3bf5819
Compare
This is because you _have_ to use a JS action (it seems, would love to be wrong) to gather the branch name on PR workflows. So we'll rely on the Percy build being correct in order to test this
Robdel12
force-pushed
the
rd/passthrough
branch
from
879e960
to
02c7278
Compare
wwilsman
reviewed
Feb 24, 2020
|
This is awesome @Robdel12, thanks for the super-fast turnaround on this! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
This allows a user to use the exec-action to only set the Percy env vars. Then the user can run Percy however they wish later in their workflow. Shout out to @agrobbin for the idea!
I also took this chance to write a few env tests to ensure this is working properly (rather than relying on the Percy build)