Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 fix shadow DOM serialization #706

Merged
merged 1 commit into from Jan 30, 2023
Merged

🐛 fix shadow DOM serialization #706

merged 1 commit into from Jan 30, 2023

Conversation

itsjwala
Copy link
Contributor

  • In this PR we're using replaceChildren rather than innerHTML for the scoped container to preserve the shadow roots.
  • This ideally shouldn't have any side effects.
  • This fixes Shadow DOM support for Ember #705
  • Note: This doesn't fix giving shadow host as scope selector.

@samarsault samarsault self-requested a review January 30, 2023 13:55
samarsault
samarsault approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@samarsault samarsault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@itsjwala itsjwala merged commit 1f5de36 into master Jan 30, 2023
@delete-merged-branch delete-merged-branch bot deleted the shadow_dom_fixes branch January 30, 2023 14:00
@itsjwala itsjwala added the 🐛 bug Something isn't working label Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarsault samarsault samarsault approved these changes

Assignees
No one assigned
Labels
🐛 bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shadow DOM support for Ember
2 participants
@itsjwala @samarsault