✨ Add support for Nightwatch 2.x #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
force-pushed
the
rd/nightwatch-2.x
branch
from
ada07c1
to
5c2462d
Compare
|
For some reason the headless arg isn't working with 2.x. That's a problem for tomorrow |
Robdel12
force-pushed
the
rd/nightwatch-2.x
branch
from
5c2462d
to
0d5a572
Compare
This also retains compatibility with Nightwatch 1.x
Robdel12
force-pushed
the
rd/nightwatch-2.x
branch
from
0d5a572
to
b630c89
Compare
wwilsman
reviewed
May 2, 2022
Robdel12
force-pushed
the
rd/nightwatch-2.x
branch
from
cce61e6
to
3a832f5
Compare
wwilsman
reviewed
May 2, 2022
Robdel12
force-pushed
the
rd/nightwatch-2.x
branch
from
3a832f5
to
69699d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Update the SDK to support both Nightwatch 1.x and 2.x. The difference is the object that's returned from the
executefunction. 1.x will return with a nestedvalueobject and 2.x does not. I also noticed 2.x no longer returns the result of the function, so I wrapped the function in a promise and resolve that promise in the callback with theexecuteresults.Bug or feature?
I struggled with what this should be. Is this a bug fix (patch) or is this a new feature since we're now adding support for 2.x?