Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add PoA Support #216

Merged
merged 22 commits into from
Jul 3, 2023
Merged

✨ Add PoA Support #216

merged 22 commits into from
Jul 3, 2023

Conversation

chinmay-browserstack
Copy link
Contributor

@chinmay-browserstack chinmay-browserstack commented May 5, 2023

Changes for POA. added a new function screenshot. will call cli with driver details.
CLI PR: percy/cli#1239
https://browserstack.atlassian.net/browse/PPLT-2047

@Amit3200
Copy link
Contributor

Amit3200 commented May 8, 2023

Add description, task and CLI PR for reference.

@samarsault samarsault changed the title POA changes ✨ Add PoA Support May 18, 2023
Copy link
Contributor

@samarsault samarsault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

chinmay-browserstack and others added 6 commits June 19, 2023 15:24
* Added logic for ignore region

* added test case

* Added validation in tests

* Possible concurrent thread fix 1

* Possible concurrent thread fix 2

* Possible concurrent thread fix 3

* Possible concurrent thread fix 4

* Possible concurrent thread fix 5
* Added logic for ignore region

* added test case

* Added validation in tests

* Possible concurrent thread fix 1

* Possible concurrent thread fix 2

* Possible concurrent thread fix 3

* Possible concurrent thread fix 4

* Possible concurrent thread fix 5

* Fix ignore region logic
@Amit3200 Amit3200 merged commit a211749 into master Jul 3, 2023
11 checks passed
@Amit3200 Amit3200 deleted the PPLT_2047 branch July 3, 2023 12:52
@shantanuk-browserstack shantanuk-browserstack added the ✨ enhancement New feature or request label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants