Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for sync CLI #14

Merged
merged 7 commits into from
Feb 1, 2024
Merged

Added support for sync CLI #14

merged 7 commits into from
Feb 1, 2024

Conversation

prklm10
Copy link
Contributor

@prklm10 prklm10 commented Jan 25, 2024

adding timeout of 600 sec for sync

lib/percy.rb Outdated
Net::HTTP.post(uri, data.to_json)
http = Net::HTTP.new(uri.host, uri.port)
http.read_timeout = 600 # seconds
request = Net::HTTP::Post.new(url.path)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
request = Net::HTTP::Post.new(url.path)
request = Net::HTTP::Post.new(uri.path)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch

lib/percy.rb Outdated Show resolved Hide resolved
@chinmay-browserstack chinmay-browserstack changed the title adding timeout of 600 sec for sync Added support for sync CLI Jan 31, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@ninadbstack ninadbstack merged commit 54fedf8 into main Feb 1, 2024
3 of 7 checks passed
@ninadbstack ninadbstack deleted the PER-2862 branch February 1, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants