Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types are missing testcafe target as first arg #108

Closed
csi-lk opened this issue May 19, 2021 · 2 comments · Fixed by #124
Closed

types are missing testcafe target as first arg #108

csi-lk opened this issue May 19, 2021 · 2 comments · Fixed by #124

Comments

@csi-lk
Copy link
Contributor

csi-lk commented May 19, 2021

The types are:

export default function percySnapshot(  name: string,  options?: SnapshotOptions): Promise<void>;

But the readme states:

percySnapshot(t, 'TestCafe Example');

Looks like the first arg is missing

@jorgjanke
Copy link

yes, in the package, the file
testcafe/types/inded.d.ts
should look like

export default function percySnapshot(
    t: TestController,
    name: string,
    options?: SnapshotOptions
): Promise<void>;

@csi-lk
Copy link
Contributor Author

csi-lk commented Jun 8, 2021

I've opened a PR to fix this here: #124

Robdel12 pushed a commit that referenced this issue Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants