Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for multi-threading #9

Merged
merged 2 commits into from Mar 29, 2014
Merged

Conversation

ajaech
Copy link
Contributor

@ajaech ajaech commented Mar 26, 2014

A new command line argument controls how many threads to use. A thread
pool is created and the main work of updating the data structures after
a cluster merge is split equally among all the threads in the pool. The
clustering can be more than 10 times as fast using multiple threads,
depending on how many cores on the CPU.

A new command line argument controls how many threads to use. A thread
pool is created and the main work of updating the data structures after
a cluster merge is split equally among all the threads in the pool. The
clustering can be more than 10 times as fast using multiple threads,
depending on how many cores on the CPU.
@ajaech
Copy link
Contributor Author

ajaech commented Mar 26, 2014

I made a few changes to make the clustering run faster by using multiple threads. I've been testing it for a couple of weeks. It gives exactly the same clustering as before except it is much faster.

makefile should now work on osx
percyliang added a commit that referenced this pull request Mar 29, 2014
add support for multi-threading
@percyliang percyliang merged commit 4080a44 into percyliang:master Mar 29, 2014
@percyliang
Copy link
Owner

Thank you - this will be very helpful to people!

-Percy

On Wed, Mar 26, 2014 at 10:30 AM, ajaech notifications@github.com wrote:

I made a few changes to make the clustering run faster by using multiple
threads. I've been testing it for a couple of weeks. It gives exactly the
same clustering as before except it is much faster.

Reply to this email directly or view it on GitHubhttps://github.com//pull/9#issuecomment-38713957
.

@arianhosseini
Copy link

what is the command line argument -t or ... ?! and how many threads are safe to use?!

@ajaech
Copy link
Contributor Author

ajaech commented Nov 24, 2015

Are you asking what the command line option is to set the number of
threads? I think it is --threads. See here
https://github.com/percyliang/brown-cluster/blob/master/wcluster.cc#L63.

It is safe to use as many threads as you want but you will probably not get
any benefit to using more threads than there are cores on your cpu.

On Tue, Nov 24, 2015 at 11:56 AM, Arian notifications@github.com wrote:

what is the command line argument -t or ... ?! and how many threads are
safe to use?!


Reply to this email directly or view it on GitHub
#9 (comment)
.

@arianhosseini
Copy link

thanks, I think adding the command line option in the Read Me would help others to understand how to use this feature.

@ajaech
Copy link
Contributor Author

ajaech commented Nov 24, 2015

When you run the script with no arguments it should print out a list of all
the arguments along with short descrptions.

On Tue, Nov 24, 2015 at 12:05 PM, Arian notifications@github.com wrote:

thanks, I think adding the command line option in the Read Me would help
others to understand how to use this feature.


Reply to this email directly or view it on GitHub
#9 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants