Rewrite / merge with sendmail backend from django-snippets #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- sendmail: use '-t' to parse recipients from mail, instead of only
sending to the first one
- do not use shell=True!
- capture stderr and use it together with returncode to raise an
exception
Ref: perenecabuto#1
- based on BaseEmailBackend (which does not append separator/newline) - return number of sent mails (as per documentation) - handle `fail_silently` I have merged https://djangosnippets.org/snippets/1864/, with the following notable changes: - write the message as_bytes() - this is what the SMTP backend does and is _probably_ the right thing to do - use `sendmail -t` (parse recipients from mails; as with my previous commit) - removed thread locking, which should not be necessary, according to https://djangosnippets.org/snippets/1864/#c4310 - likely copied from the SMTP backend - raise an Exception in case of error (as with my previous commit)
|
Some notes: the Exception might be changed, I have probably not looked hard enough to find a better, already existing class for this. Also the text, maybe. |
|
@perenecabuto could you have a look on this change? Would be useful to have it on pypi as soon as possible. |
perenecabuto
added a commit
that referenced
this pull request
Mar 12, 2014
Rewrite / merge with sendmail backend from django-snippets
|
I have accepted the pull request and uploaded to pypi as version 0.1.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have merged https://djangosnippets.org/snippets/1864/, with the following notable changes:
and is probably the right thing to do
sendmail -t(parse recipients from mails; as with my previous commit)https://djangosnippets.org/snippets/1864/#c4310 - likely copied from
the SMTP backend
See the commits for more information.