Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to using pyproject.toml #121

Merged
merged 1 commit into from
Oct 11, 2023
Merged

Switch to using pyproject.toml #121

merged 1 commit into from
Oct 11, 2023

Conversation

viktordick
Copy link
Collaborator

No description provided.

@viktordick
Copy link
Collaborator Author

The goal here is to publish this on pypi. Tutorials I have read for this (in particular https://realpython.com/pypi-publish-python-package/) recommend changing to using pyproject.toml instead of setup.py.

jan-jockusch
jan-jockusch approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@jan-jockusch jan-jockusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viktordick viktordick merged commit 6d798a1 into master Oct 11, 2023
3 checks passed
@viktordick viktordick deleted the package-toml branch October 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-jockusch jan-jockusch jan-jockusch approved these changes

@Wiseqube Wiseqube Awaiting requested review from Wiseqube

@gandie gandie Awaiting requested review from gandie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@viktordick @jan-jockusch