T252577: Tell about older tox versions no longer working #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viktordick
reviewed
Feb 19, 2024
README.md
Outdated
| @@ -310,4 +310,9 @@ containing broken `External Method`s are recorded and played back. The same | |||
| holds for `Z SQL Method`s which have `class_name` and `class_file` set to a no | |||
| longer existing extension. | |||
|
|
|||
| Since `22.2.5` the latest version of `tox` is required in order to build the | |||
There was a problem hiding this comment.
Maybe a formulation like "a recent enough version" may be better here?
There was a problem hiding this comment.
Well "recent enough" was too vague for my taste. Ran through changelog and tested, version 3.26.0 is the first one working again, which corresponds nicely with the bugfixes mentioned as we use isolated_build nowadays:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention nasty version struggle in Caveats chapter. There are even more traps behind the initial error shown, so people should know and just take the right steps.