Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method that exposes reading the db_modtime #126

Merged
merged 1 commit into from
Apr 22, 2024
Merged

Conversation

viktordick
Copy link
Collaborator

No description provided.

@viktordick
Copy link
Collaborator Author

Just had a crazy idea - instead of appending each object with its modtime, which becomes difficult with an application where we want to do more logic in the client, we just initially transfer the "code modtime" to the client and have helper functions there that simply append this modtime to all AJAX requests (or at least requests that are marked as "cacheable"). That way, we have nice performance on a system that does not change much, don't need to spend any time on the server obtaining the modtime of any resource that the client may later request, and don't have the problem of hunting for bugs that are simply there because the browser still uses an old JS file and Control+Shift+R only works for the immediately fetched ressources, not for those that are later added with AJAX.

@jan-jockusch
Copy link
Member

Doesn't sound so crazy to me… in any case, exposing it can open up that possibility.

Copy link
Member

@jan-jockusch jan-jockusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@viktordick viktordick merged commit 670fcea into master Apr 22, 2024
3 checks passed
@viktordick viktordick deleted the add-db-modtime branch April 22, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants