Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make webpage test URL configurable #2

Closed
redonkulus opened this issue Mar 2, 2016 · 3 comments
Closed

Make webpage test URL configurable #2

redonkulus opened this issue Mar 2, 2016 · 3 comments

Comments

@redonkulus
Copy link

At my company, we have an internal instance of webpacktest to test internal URLs. Would be nice to make this configurable in the tool:

https://github.com/perflint/perflint/blob/master/lib/service/webpagetest.js#L114

@matthojo
Copy link
Member

matthojo commented Mar 2, 2016

Great idea. I'll see if I can get this into the next release, shouldn't be too difficult.

@redonkulus redonkulus changed the title Make webpack test URL configurable Make webpage test URL configurable Mar 2, 2016
matthojo added a commit that referenced this issue Mar 3, 2016
@matthojo
Copy link
Member

matthojo commented Mar 3, 2016

Started work on this with 578bd1d.

Remaining work;

  • Tests still need adding
  • Validate it works with real custom WPT servers
  • Allow server to be set with environment variable - eaa5ade

@matthojo matthojo added this to the v0.1.0 - Beta milestone Mar 3, 2016
@matthojo
Copy link
Member

This is now available on v0.0.3.
Documentation: https://perflint.readme.io/v0.0.3/docs/command-line-interface#-s-server-string

I'll close once tests and there is validation of it working with hosted WPT servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants