impl: avoid creating logger if possible

perfmark · May 16, 2021 · be6ddaf · be6ddaf
1 parent cbe384d
commit be6ddaf
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/impl/src/main/java/io/perfmark/impl/Storage.java b/impl/src/main/java/io/perfmark/impl/Storage.java
@@ -46,7 +46,6 @@ public final class Storage {
       new ConcurrentHashMap<MarkHolderRef, Boolean>();
   private static final ThreadLocal<MarkHolder> localMarkHolder = new MarkHolderThreadLocal();
   static final MarkHolderProvider markHolderProvider;
-  private static final Logger logger;
 
   static {
     List<MarkHolderProvider> providers = new ArrayList<MarkHolderProvider>();
@@ -94,13 +93,15 @@ public final class Storage {
       markHolderProvider = new NoopMarkHolderProvider();
     }
 
-    logger = Logger.getLogger(Storage.class.getName());
+    if (!warnings.isEmpty() || !fines.isEmpty()) {
+      Logger logger = Logger.getLogger(Storage.class.getName());
 
-    for (Throwable error : warnings) {
-      logger.log(Level.WARNING, "Error loading MarkHolderProvider", error);
-    }
-    for (Throwable error : fines) {
-      logger.log(Level.FINE, "Error loading MarkHolderProvider", error);
+      for (Throwable error : warnings) {
+        logger.log(Level.WARNING, "Error loading MarkHolderProvider", error);
+      }
+      for (Throwable error : fines) {
+        logger.log(Level.FINE, "Error loading MarkHolderProvider", error);
+      }
     }
   }