add P4CHARSET support with yaml config format #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Alan - as discussed via Slack, it would be helpful if you could add a test or two. You have prompted me to put some notes on testing in the docs! |
|
p.s. I have added a GitHub workflow for tests - it is not yet auto-triggering - but it does work if run manually. |
|
Thanks Alan - good that test breakages are fixed. Can you add a test to show that a source/target server with charset required actually works. Duplicate a simple test like testAdd and customize the setup for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated p4transfer.py to generate P4CHARSET config in yaml format