Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Parfait to support log4j2 #71

Closed
tallpsmith opened this issue Sep 10, 2020 · 1 comment
Closed

Upgrade Parfait to support log4j2 #71

tallpsmith opened this issue Sep 10, 2020 · 1 comment

Comments

@tallpsmith
Copy link
Contributor

tallpsmith commented Sep 10, 2020

Log4j1.2 is now end of life. There are some key spots where Parfait uses Log4j's MDC context which will need to be migrated during the journey to Log4j2.

There are a few areas that we need to consider, and this might warrant separating these into a separate module (due to library dependencies). We could also decide whether to continue to support log4j1.2 at all.

Areas affected:

  • io.pcp.parfait.timing.ThreadContext.MdcBridge
  • General use of log4j1.2 logging (parfait-agent, and QuiescentRegistryListener)
@natoscott
Copy link
Member

Yeah, nah. :-) See commit #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants