pmproxy / libpcp_web multithreading, http and https/tls fixes, QA #1321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a mutex to the local webgroups structure in libpcp_web and use it to protect multithreaded parallel updates (dictAdd, dictDelete) to the groups->contexts dict and the dict traversal in the timer driven garbage collector. Tested by qa/297 and related tests and also an updated version of qa/1457 (which now stress tests parallel http and https/tls pmproxy RESTAPI calls .. in a later commit). Related: RHBZ#1947989 Resolves: performancecopilot#1311
Add a new mutext to struct proxy and use it to protect parallel multithreaded updates to the proxy->first client list. Also use the same mutext to protect updates to the pending_writes client list and avoid the doubly linked list corruption that was causing parallel https/tls requests to get stuck spinning in flush_secure_module(), as reported in BZ#1947989. qa/1457 is extensively updated to test parallel http, https/tls (and combinations of http and https/tls) RESTAPI calls. Previously it only tested a single https/tls call. With these changes, parallel https/tls RESTAPI requests from the grafana-pcp datasource to pmproxy now work correctly whereas previously pmproxy would hang/spin. Resolves: RHBZ#1947989 - pmproxy hangs and consume 100% cpu if the redis datasource is configured with TLS. Related: performancecopilot#1311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves BZ 1947989 - pmproxy hangs and consume 100% cpu if the redis datasource is configured with TLS
Resolves #1311
Related #1203, qa/297 and qa/1290
Tested with updates to qa/1457