metrics: add support for multidimensional composite metrics #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds support for multidimensional metrics based on @saurvs's work in hornet without introducing any breaking behavior. Existing enums work, a megabyte/second unit can be initialized as ```go u := speed.MegabyteUnit.Time(speed.SecondUnit, -1) ``` - adds a `Reset` nethod on Timer, which allows reseting the timer's stored elapsed time back to zero - a new example to demonstrate construction of composite units as well as the `Reset` function - corresponding changes in MMVDump with an updated dunp syntax for units based on hornet. Additional test case added and existing modified to accomodate the change.
|
@natoscott please review |
natoscott
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for multidimensional metrics based on @saurvs's work in
hornet without introducing any breaking behavior. Existing enums work,
a megabyte/second unit can be initialized as
adds a
Resetnethod on Timer, which allows reseting the timer'sstored elapsed time back to zero
a new example to demonstrate construction of composite units as well
as the
Resetfunctioncorresponding changes in MMVDump with an updated dunp syntax for units
based on hornet. Additional test case added and existing modified to
accomodate the change.