Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restored the groups widget to the dashboard #327

Merged
merged 1 commit into from Oct 30, 2020
Merged

Restored the groups widget to the dashboard #327

merged 1 commit into from Oct 30, 2020

Conversation

timdunn22
Copy link

@timdunn22 timdunn22 commented Oct 28, 2020 •
edited

What does this PR do?

  1. Adds the group tags to the dashboard.
  2. Closes Restore groups widget on dashboard with links to filtered document index #325

How to test?

  1. Login to https://cove-studio-issue-325-oji1b1va.herokuapp.com/
  2. Click on dashboard and make sure that you are able to see the Editions widget.

@timdunn22
Copy link
Author

Screen Shot 2020-10-28 at 18 49 49

@jamiefolsom I assume this is what you are referencing

@jamiefolsom
Copy link
Member

@timdunn22 yes -- that's right.

jamiefolsom
jamiefolsom approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine -- please change the title of the PR to: "Restored the groups widget to the dashboard", and remove "WIP".

@timdunn22 timdunn22 changed the title WIP: Add group tag to dashboard Restored the groups widget to the dashboard Oct 28, 2020
@jamiefolsom jamiefolsom temporarily deployed to cove-studio-issue-325-oji1b1va October 30, 2020 18:56 Inactive
@jamiefolsom jamiefolsom merged commit 2d52287 into master Oct 30, 2020
@jamiefolsom jamiefolsom temporarily deployed to cove-staging October 30, 2020 18:57 Inactive
@jamiefolsom jamiefolsom deleted the issue_325 branch October 30, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamiefolsom jamiefolsom jamiefolsom approved these changes

Assignees

@SteveMarvin SteveMarvin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restore groups widget on dashboard with links to filtered document index
3 participants
@timdunn22 @jamiefolsom @SteveMarvin