AS #394 - Redesign navbar and add NASSR logo #400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiefolsom
approved these changes
Mar 18, 2022
add NASSR logo to all brand views remove extra slash from NASSR URL hide logos on small screens compile CSS changes use hamburger menu in navbar center items in dropdown menu make the brand text smaller on all displays display logos in mobile dropdown menu make login dropdown centered in mobile dropdown hide logos on tablet-size screens expand width to hide logos update alabama brand with new navbar update bavs brand with new navbar update styles to center all forms in mobile dropdown switch remaining tenants to new navbar
camdendotlol
force-pushed
the
cm/nassr-logo
branch
from
95daa36
to
413087e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
For the navbar redesign, I stuck to the Bootstrap 3.1.1 classes that the rest of AS uses, as well as a few custom styles.
Before
Screen.Recording.2022-03-18.at.12.14.12.PM.mov
After
Screen.Recording.2022-03-18.at.12.10.26.PM.mov
How to test
Visit as many parts of the site as possible on various screen sizes and make sure the navbar...
I would give some links to different sections of the site, but I'm not familiar with all that's on there and I don't have access to the document view.