Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add attribution and tile source fields #35

Merged
merged 1 commit into from Jul 19, 2018
Merged

Conversation

akstuhl
Copy link
Contributor

@akstuhl akstuhl commented Jul 12, 2018

What does this PR do?

  • Adds 'o:tile_address' text field to exhibit schema for adding custom image-based tile sources to the map in Neatline 3
  • Adds 'o:image_attribution', 'o:wms_attribution', and 'o:tile_attribution' text fields to exhibit schema to accommodate attribution for manually configured base layers.
  • Increments the module version to 3.0.1 in order to provide the above fields through an upgrade-triggered migration.
  • Updates the asset/neatline submodule to reflect the present state of the master branch in https://github.com/performant-software/neatline-3
  • Removes unused admin views from early development

What issues does it address?

How to test

  • Testing will depend on front-end implementation of tile source base layer and attribution properties in https://github.com/performant-software/neatline-3
  • Note: this change increments the version number of the Neatline module for Omeka S and includes a database migration. After pulling this code, you will need to visit the Admin -> Modules view in your Omeka S instance and click Upgrade in the row for Neatline. This will run the database migration.

Copy link
Member

@jamiefolsom jamiefolsom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 !

@feralresearch
Copy link
Contributor

Looks good except I seem to be missing the "o:image_address" field now. Sorry it took me a while to catch this...

screen shot 2018-07-17 at 1 00 24 am

@akstuhl
Copy link
Contributor Author

akstuhl commented Jul 16, 2018

@tezcatlipoca the 'o:image_layer' field is used for external static image URLs ('image_address' would be more consistent, but not worth adding a migration step in my opinion)

remove unused admin views

update front-end submodule
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants