Skip to content

Commit

Permalink
Made table.js clear table function way faster.
Browse files Browse the repository at this point in the history
  • Loading branch information
Baklap4 committed Jun 4, 2018
1 parent 6643fa0 commit 0c0e772
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion data/themes/default/www/database.html
Expand Up @@ -12,7 +12,7 @@
<div class="col-sm-12">
<div class="table-responsive">
<table id="database-songs" class="table table-striped table-hover">
<tr id="database-table-header">
<tr id="table-header">
<th><a id="sort-by-artist" href="#" data-sort-ascending="true">artist<span class="glyphicon glyphicon-menu-down"></span></a></th>
<th><a id="sort-by-title" href="#" data-sort-ascending="true">title<span class="glyphicon glyphicon-menu-down"></span></a></th>
<th class="hidden-xs"><a id="sort-by-language" href="#" data-sort-ascending="true">language<span class="glyphicon glyphicon-menu-down"></span></a></th>
Expand Down
4 changes: 2 additions & 2 deletions data/themes/default/www/js/database.js
Expand Up @@ -13,7 +13,7 @@
$("#refresh-database").click(function () {
$.get("api/getDataBase.json", function (data) {
var database = data;
clearTable("#database-songs > tbody");
clearTable("database-songs");

var html = buildTable(database);
$(html).appendTo("#database-songs");
Expand Down Expand Up @@ -44,7 +44,7 @@ $("a[id^='sort-by-']").click(function () {
$.get(url, function (data) {
var database = data;

clearTable("#database-songs > tbody");
clearTable("database-songs");

var html = buildTable(database);
$(html).appendTo("#database-songs");
Expand Down
9 changes: 5 additions & 4 deletions data/themes/default/www/js/table.js
Expand Up @@ -37,8 +37,9 @@ function buildTable(database) {
This function is used within 'database.js'.
*/
function clearTable(selector) {
var tbody = $(selector);
while (tbody.children().length > 1) {
tbody.children().last().remove();
}
var tbody = document.getElementById(selector).getElementsByTagName('tbody')[0];
var tbodyHeader = document.getElementById("table-header");
var newTbody = document.createElement('tbody');
newTbody.appendChild(tbodyHeader);
tbody.parentNode.replaceChild(newTbody, tbody);
}

0 comments on commit 0c0e772

Please sign in to comment.