fix(job-runner-bundle): job update too big

perfsee · Oct 19, 2022 · 34f3f98 · 34f3f98
1 parent a7e09af
commit 34f3f98
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 11 deletions.
diff --git a/packages/runner/bundle/src/bundle/index.ts b/packages/runner/bundle/src/bundle/index.ts
@@ -38,7 +38,7 @@ import {
   JobType,
   BundleJobEntryPoint,
 } from '@perfsee/server-common'
-import { BundleAuditWarning, BundleResult, diffBundleResult } from '@perfsee/shared'
+import { briefEntryDiff, BundleAuditWarning, BundleResult, diffBundleResult } from '@perfsee/shared'
 
 export class BundleWorker extends JobWorker<BundleJobPayload> {
   private pwd!: string
@@ -154,7 +154,7 @@ export class BundleWorker extends JobWorker<BundleJobPayload> {
     const result: Record<string, BundleJobEntryPoint> = {}
 
     for (const entryPointName in diffResult) {
-      const entryPoint = diffResult[entryPointName]
+      const entryPoint = briefEntryDiff(diffResult[entryPointName])
       const warnings = this.generateWarnings(
         jobResult.entryPoints.find(({ name }) => name === entryPointName)!,
         baselineResult?.entryPoints?.find(({ name }) => name === entryPointName),

diff --git a/packages/server-common/src/types/index.ts b/packages/server-common/src/types/index.ts
@@ -19,11 +19,11 @@ import {
   FlameChartDiagnostic,
   Size,
   BundleAuditWarning,
-  EntryDiff,
   HeaderType,
   CookieType,
   MetricKeyType,
   LocalStorageType,
+  EntryDiffBrief,
 } from '@perfsee/shared'
 
 type PartialSnapshotReport = {
@@ -73,7 +73,7 @@ export interface BundleJobPayload {
   baselineReportKey?: string | null
 }
 
-export type BundleJobEntryPoint = EntryDiff & {
+export type BundleJobEntryPoint = EntryDiffBrief & {
   name: string
   warnings: BundleAuditWarning[]
 }

diff --git a/packages/shared/src/bundle/diff.ts b/packages/shared/src/bundle/diff.ts
@@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
-import { keyBy, sortBy, uniq } from 'lodash'
+import { keyBy, sortBy, uniq, pick } from 'lodash'
 
 import {
   Asset,
@@ -127,26 +127,47 @@ export function parseResult(job: BundleResult) {
   }
 }
 
-export interface EntryDiff {
-  assetsDiff: Diff<AssetInfo[]>
+export interface EntryDiffBrief {
   assetsCountDiff: Diff<number>
   sizeDiff: Diff
   initialSizeDiff: Diff
   initialJsSizeDiff: Diff
   initialCssSizeDiff: Diff
-  initialAssetsDiff: Diff<AssetInfo[]>
   jsSizeDiff: Diff
   cssSizeDiff: Diff
-  chunksDiff: Diff<Chunk[]>
-  packagesDiff: Diff<PackageInfo[]>
   cacheInvalidation: Diff
   chunksCountDiff: Diff<number>
   packagesCountDiff: Diff<number>
   duplicatedPackagesCountDiff: Diff<number>
+  score: Diff<number | undefined>
+}
+
+export interface EntryDiff extends EntryDiffBrief {
+  assetsDiff: Diff<AssetInfo[]>
+  initialAssetsDiff: Diff<AssetInfo[]>
+  chunksDiff: Diff<Chunk[]>
+  packagesDiff: Diff<PackageInfo[]>
   duplicatedPackages: DuplicatePackage[]
   packageIssueMap: PackageIssueMap
   audits: BundleAuditResult[]
-  score: Diff<number | undefined>
+}
+
+export function briefEntryDiff(entryDiff: EntryDiff): EntryDiffBrief {
+  return pick(
+    entryDiff,
+    'assetsCountDiff',
+    'sizeDiff',
+    'initialSizeDiff',
+    'initialJsSizeDiff',
+    'initialCssSizeDiff',
+    'jsSizeDiff',
+    'cssSizeDiff',
+    'cacheInvalidation',
+    'chunksCountDiff',
+    'packagesCountDiff',
+    'duplicatedPackagesCountDiff',
+    'score',
+  )
 }
 
 export interface BundleDiff {