Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pscheduler-server RPM fail when postgresql-load does #110

Closed
mfeit-internet2 opened this issue Sep 3, 2016 · 5 comments
Closed

Make pscheduler-server RPM fail when postgresql-load does #110

mfeit-internet2 opened this issue Sep 3, 2016 · 5 comments
Assignees
Labels

Comments

@mfeit-internet2
Copy link
Member

mfeit-internet2 commented Sep 3, 2016

The calls to postgresql-load in the pscheduler-server RPM spec cause the scriptlet to stop on error, but for some internal, RPM-related reason, the whole operation continues.

Discussion:

Try to find a workaround for this.

@mfeit-internet2
Copy link
Member Author

Consider doing a test load of the finished SQL into a temporary database during the build instead of depending on loads failing during installation.

@mfeit-internet2
Copy link
Member Author

Arranged a syntax check during build to keep silly mistakes from getting into production.

Because this requires a running PostgreSQL server, the Makefile will not do the check unless CHECK_SYNTAX is defined. The RPM spec does this; the Debian packagers can set this if/when they're ready to do this. (Since Debian is effectively a port of the CentOS version, the developers should catch most things before they reach Debian.)

@vvidic
Copy link
Contributor

vvidic commented Dec 7, 2016

Sound good to make this optional. We can than try to integrate this check in the test part of the package build or in the post-build package tests.

@vvidic
Copy link
Contributor

vvidic commented Dec 8, 2016

On the Debian side the package install will fail if the database does not load properly so basic testing should reveal any problems here.

@arlake228 arlake228 removed this from the 1.1 milestone May 8, 2017
@mfeit-internet2 mfeit-internet2 added this to the hackathon-20190520 milestone Mar 21, 2019
@mfeit-internet2 mfeit-internet2 self-assigned this Mar 21, 2019
@mfeit-internet2 mfeit-internet2 removed this from the hackathon-20190520 milestone Mar 21, 2019
@mfeit-internet2
Copy link
Member Author

Checking syntax during build seems to have prevented these kinds of problems. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants