Multiple storage drivers. #273

GrzegorzDrozd · 2019-08-04T21:27:04Z

Introduce multiple storage drivers, currently supported are:

pdo.sqlite
pdo.mysql
pdo.postgresql
mongo
files

All current Unit tests are updated and all in green. I did extensive testing and everything except custom views is working ok. Custom views will have to be rethink because it is impossible to support them with storage different than mongo in the current form.

This also requires collector changes:

Introduce multiple storage drivers xhgui-collector#28

…mongo. New classes for storage New class for filtering New class for watched function storage template updates other changes. Initial commit. Known issues: - unit tests are not working - javascript date time picker does not work - custom view does not work - search filters should expose more fields

# Conflicts: # config/config.default.php # src/Xhgui/Controller/Run.php # src/Xhgui/Controller/Watch.php # src/Xhgui/Controller/Waterfall.php # src/Xhgui/Searcher/Mongo.php # src/Xhgui/ServiceContainer.php # src/Xhgui/WatchFunctions.php

Merge fixes

RunController tests

Missing run controller tests.

Changing some code to work better with testing.

…orking

fix common test class

Change filename generation

Add different db schema files Fix import

Make custom view avalible only for mongodb for now.

Add missing tests for import controller.

Allow argument in url to be only date

Postgresql cannot easily cast jsonb to text, use native search capabilities of both mysql and pg. For pg versions lower than 5.6 it can be disabled setting variable in config.

Fix missing cookie and ip filtering.

GrzegorzDrozd · 2019-08-06T08:49:30Z

Hi @markstory, this code is ready for review.

glensc · 2019-08-19T08:52:28Z

@GrzegorzDrozd could you please rebase (not merge) the changes against origin/master and consider squashing commits to a minimum. I can do the review as well.

GrzegorzDrozd · 2019-08-21T15:28:23Z

@glensc I will try to do that tonight but I am not used to do rebases - I hope I will not break anything.

GrzegorzDrozd · 2019-08-28T10:49:14Z

I have some computer issues and I am waiting for a new machine. I will get back to this PR asap.

- make sure no array uses short syntax - rename PDO to Pdo

- remove all unnecessary code changes and formatting.

GrzegorzDrozd · 2019-09-11T21:53:49Z

@GrzegorzDrozd could you please rebase (not merge) the changes against origin/master and consider squashing commits to a minimum. I can do the review as well.

Hi. I have tried to do rebase couple of times but I don't know how to do that properly. Code never worked after that. I removed all unnecessary code changes from my branch. I can do following: make new clean branch with just current state of the code, will that work ?

glensc · 2019-09-13T12:44:40Z

You can re-create the branch, but lets not create another PR, as this already contains the review comments.

Just important is to push your new branch to the branch this PR is based against: GrzegorzDrozd:master

And need git push -f to overwrite commits.

glensc · 2020-04-16T13:47:39Z

@GrzegorzDrozd do you have a checklist whats holding to get this merged?

Really hate to lose huge work like this because its acceptance got stalled.

I'm thinking maybe just go with one squash merge commit, i.e forget the beautiful git history

glensc · 2020-04-18T16:40:04Z

src/Xhgui/Controller/Import.php

+        $this->_template = '';
+
+        $readConfig = $this->app->container->get('settings');
+        $saveHandlerConfig = $this->app->container->get('settings');


$readConfig and $saveHandlerConfig are identical

alfredbez · 2020-06-18T13:10:28Z

This looks very useful, maybe I find some time to help here.

alfredbez · 2020-06-18T13:24:55Z

Unfortunately, @GrzegorzDrozd has no interest in working further on this PR and decided to maintain his own version in this Github Org: https://github.com/phpperftools/

@GrzegorzDrozd is it ok for you if I take this over?

GrzegorzDrozd · 2020-06-18T14:04:32Z

Unfortunately, @GrzegorzDrozd has no interest in working further on this PR and decided to maintain his own version in this Github Org: https://github.com/phpperftools/

@GrzegorzDrozd is it ok for you if I take this over?

Of course :) Not a problem for me :) Go ahead.

glensc · 2020-06-18T18:49:50Z

I think @GrzegorzDrozd work is based on older version and has conflicting changes now that #244 is merged.

see:

Introduce multiple storage drivers xhgui-collector#28 (comment)

but as this PR was made from "master" branch, the contents of this PR and what was intended to be submitted is unknown.

I personally think that all adapters other than upload should be deprecated
so that from the application you only need some form of HTTP client to submit data to xhgui server. and then it really doesn't matter what xgui uses internally to store data.

I also started new project for the client, trying to cleanup API needed at client side.

https://github.com/perftools/php-profiler

glensc · 2020-06-18T18:52:51Z

this is not suitable for merge or review. submit changes in smaller chunks and per feature.

Grzegorz Drozd added 30 commits May 19, 2019 18:15

Merge remote-tracking branch 'origin/master'

7598fe5

# Conflicts: # config/config.default.php # src/Xhgui/Controller/Run.php # src/Xhgui/Controller/Watch.php # src/Xhgui/Controller/Waterfall.php # src/Xhgui/Searcher/Mongo.php # src/Xhgui/ServiceContainer.php # src/Xhgui/WatchFunctions.php

sqlite db schema

68fd46a

Code quality fixes

9093fd4

Merge fixes

Initial tests

897110b

RunController tests

Missing test cases

2f844fa

Watch function tests.

64d2c11

Missing run controller tests.

Fixing existing tests, adding new tests

cb0c7ad

Changing some code to work better with testing.

fix test runner on travis

2d72de2

debug

bf1f225

remove debug

0c4956c

debug

2edcb1b

Fix typo

7e8da56

enable default file handler so that tests and new installations are w…

5f64334

…orking

Fix config

e40043e

fix common test class

fix broken test

16ff214

Import suppoer

bc86e44

Stickler-ci code style fixes.

367cdd4

Change filename generation

Stickler-ci code style fixes.

33abc65

Stickler-ci code style fixes.

373ff06

Stickler-ci code style fixes.

07bb7d2

Merge master

a6b53d9

Merge upstram/master

4a06e94

Package name - lower case for composer 2.0

f1ca848

Fix failing tests

cc0a7cd

Add different db schema files Fix import

Fix custom view

3456b08

Make custom view avalible only for mongodb for now.

Fix test code check

c98ed49

Mongo is no longer needed to run unittests

4980807

Add missing filter function for profile view.

3d57a97

Add missing tests for import controller.

Restore datepicker

d87b2be

Allow argument in url to be only date

Grzegorz Drozd added 9 commits August 4, 2019 15:37

Fix postgres and mysql native json search.

08f0bf8

Postgresql cannot easily cast jsonb to text, use native search capabilities of both mysql and pg. For pg versions lower than 5.6 it can be disabled setting variable in config.

Fix form

f6e8c55

Switch mongo url match to regexp.

b04365b

Fix missing cookie and ip filtering.

Fix missing ip and cookie matching for files

4144c16

stickler fixes

9e4dd84

stickler fixes

3b1e29c

stickler fixes

e2b895a

restore collector repository so that build is green

87e0095

restore collector repository so that build is green

197e22b

GrzegorzDrozd mentioned this pull request Aug 18, 2019

Sqlite backend support #234

Closed

Grzegorz Drozd added 2 commits September 11, 2019 23:20

Code review changes

6c534eb

- make sure no array uses short syntax - rename PDO to Pdo

Code review fixes:

504c98e

- remove all unnecessary code changes and formatting.

stickler fixes

1eea330

glensc mentioned this pull request Apr 18, 2020

Introduce multiple storage drivers #268

Closed

11 tasks

GrzegorzDrozd mentioned this pull request Apr 18, 2020

Introduce multiple storage drivers perftools/xhgui-collector#28

Closed

glensc reviewed Apr 18, 2020

View reviewed changes

glensc closed this Jun 18, 2020

glensc mentioned this pull request Jul 9, 2020

Release 1.0.0 stable api perftools/php-profiler#15

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiple storage drivers. #273

Multiple storage drivers. #273

GrzegorzDrozd commented Aug 4, 2019 •

edited by glensc

Loading

GrzegorzDrozd commented Aug 6, 2019

glensc commented Aug 19, 2019

GrzegorzDrozd commented Aug 21, 2019

GrzegorzDrozd commented Aug 28, 2019

GrzegorzDrozd commented Sep 11, 2019

glensc commented Sep 13, 2019 •

edited

Loading

glensc commented Apr 16, 2020

glensc Apr 18, 2020

alfredbez commented Jun 18, 2020

alfredbez commented Jun 18, 2020

GrzegorzDrozd commented Jun 18, 2020

glensc commented Jun 18, 2020

glensc commented Jun 18, 2020

Multiple storage drivers. #273

Multiple storage drivers. #273

Conversation

GrzegorzDrozd commented Aug 4, 2019 • edited by glensc Loading

GrzegorzDrozd commented Aug 6, 2019

glensc commented Aug 19, 2019

GrzegorzDrozd commented Aug 21, 2019

GrzegorzDrozd commented Aug 28, 2019

GrzegorzDrozd commented Sep 11, 2019

glensc commented Sep 13, 2019 • edited Loading

glensc commented Apr 16, 2020

glensc Apr 18, 2020

Choose a reason for hiding this comment

alfredbez commented Jun 18, 2020

alfredbez commented Jun 18, 2020

GrzegorzDrozd commented Jun 18, 2020

glensc commented Jun 18, 2020

glensc commented Jun 18, 2020

GrzegorzDrozd commented Aug 4, 2019 •

edited by glensc

Loading

glensc commented Sep 13, 2019 •

edited

Loading