Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run/import: Add http status code on errors #297

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Run/import: Add http status code on errors #297

merged 1 commit into from
Aug 21, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Jul 15, 2020

  • status 401 if token validation failed
  • status 500 on any other exception

@glensc glensc requested a review from a team July 15, 2020 20:14
@glensc glensc self-assigned this Jul 15, 2020
markstory
markstory reviewed Jul 21, 2020
View reviewed changes
Copy link
Member

@markstory markstory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Should we add tests for these response codes to the existing tests?

@glensc
Copy link
Contributor Author

glensc commented Jul 23, 2020

Can revisit this after #301

@glensc glensc merged commit 98a7a21 into perftools:master Aug 21, 2020
@glensc glensc deleted the token-status-code branch August 21, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markstory markstory markstory left review comments

@Krinkle Krinkle Krinkle approved these changes

Assignees

@glensc glensc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@glensc @markstory @Krinkle