Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix RunTest::testIndexWithSearch for Pdo searcher #337

Merged
merged 1 commit into from
Oct 1, 2020

Conversation

glensc
Copy link
Contributor

@glensc glensc commented Sep 24, 2020

It expects direction parameter passed by:

2) XHGui\Test\Controller\RunTest::testIndexWithSearch
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'asc'
+'desc'

this includes one fix to backends disparity:

@glensc glensc self-assigned this Sep 24, 2020
@glensc
Copy link
Contributor Author

glensc commented Sep 24, 2020

the hardcoded 'desc' was added in e53cc4d via #244

edit: the commit before squashing: 949134f

@1ma if you could shed some light was there a reason for that it would be awesome.

@1ma
Copy link
Contributor

1ma commented Sep 24, 2020

Can't think of any good reason, I only got to a partial implementation.

In line 194 the DESC clause is hardcoded in the SQL query, if you are going to fix this I guess you should amend that too.

@glensc glensc force-pushed the fix-direction-pdo-searcher branch 2 times, most recently from 1b05556 to 253a147 Compare September 29, 2020 11:34
It expects direction parameter passed by
@glensc glensc merged commit d3de027 into master Oct 1, 2020
@glensc glensc deleted the fix-direction-pdo-searcher branch October 1, 2020 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants