[NODEJS-1767] Make type dectection way better

Fix an issue that some entry point cannot run well under GET mode
peri18 · Oct 29, 2014 · 6dd925d · 6dd925d
1 parent bb9dac9
commit 6dd925d
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 6 deletions.
diff --git a/lib/rest.js b/lib/rest.js
@@ -30,10 +30,19 @@ var acsRequest = function(apiEntryPoint, appOptions, httpMethod, reqBody, restOp
 	}
 	var requestParam = null;
 	if (httpMethod === 'GET') {
+		var reqQueryString = {};
+		for (var item in reqBody) {
+			var value = reqBody[item];
+			if (u.typeOf(value) === 'object') {
+				reqQueryString[item] = JSON.stringify(value);
+			} else {
+				reqQueryString[item] = value.toString();
+			}
+		}
 		requestParam = {
 			url: apiEntryPoint,
 			method: httpMethod,
-			qs: JSON.stringify(reqBody),
+			qs: reqQueryString,
 			jar: j
 		};
 	} else {

diff --git a/test/users.test.js b/test/users.test.js
@@ -26,11 +26,7 @@ describe('Users Test', function() {
 	describe('.queryAndCountUsers', function() {
 		it('Should return all users', function(done) {
 			this.timeout(20000);
-			acsApp.usersQuery({
-				where: {
-					username: acsUsername
-				}
-			}, function(err, result) {
+			acsApp.usersQuery(function(err, result) {
 				assert.ifError(err);
 				assert(result);
 				assert(result.body);
@@ -102,6 +98,26 @@ describe('Users Test', function() {
 				done();
 			});
 		});
+
+		it('Should query user correctly', function(done) {
+			this.timeout(20000);
+			acsApp.usersQuery({
+				where: {
+					username: acsUsername
+				}
+			}, function(err, result) {
+				assert.ifError(err);
+				assert(result.body);
+				assert(result.body.meta);
+				assert.equal(result.body.meta.code, 200);
+				assert.equal(result.body.meta.method_name, 'queryUsers');
+				assert(result.body.response);
+				assert(result.body.response.users);
+				assert(result.body.response.users[0]);
+				assert.equal(result.body.response.users[0].username, acsUsername);
+				done();
+			});
+		});
 	});
 
 	describe('.loginUser', function() {