Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require --organization-name for users me subcommand #135

Merged
merged 2 commits into from Feb 21, 2024
Merged

Conversation

KronicDeth
Copy link
Contributor

Reproduction Steps

  • git checkout main
  • cargo build --release
  • Ensure no config is setup for the CLI.
  • Run users me against the production API without --organization-name option: ./target/release/peridio-cli --api-key=<PRODUCTION_API_KEY> users me
  • VERIFY error is printed
    error: The following arguments are required at the global level:
    
      --organization-name
    

Test Plan

  • git checkout ENG-1330
  • cargo build release
  • Ensure no config is setup for the CLI.
  • Run users me against the production API without --organization-name option: ./target/release/peridio-cli --api-key=<PRODUCTION_API_KEY> users me
  • VERIFY User JSON is printed: {"data":{"email":<EMAIL>,"username":<USERNAME>}}

The API command to get the current user doesn't require an organization because users aren't scoped to organizations.
Copy link
Contributor

@danielspofford danielspofford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified reproduction and test plan 👍

@KronicDeth KronicDeth merged commit 8ca290b into main Feb 21, 2024
5 checks passed
@KronicDeth KronicDeth deleted the ENG-1330 branch February 21, 2024 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants