Focused specs #199
Merged
Focused specs #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 96.97% (diff: 100%)@@ master #199 diff @@
==========================================
Files 20 20
Lines 645 695 +50
Methods 162 173 +11
Messages 0 0
Branches 0 0
==========================================
+ Hits 624 674 +50
Misses 21 21
Partials 0 0
|
|
@ezzatron were we going to merge this as part of our release party together? Should I merge this now? No rush on anything. Just want to make sure I'm not blocking things up. |
|
I would say this one can get merged, since it won't get tagged til we release anyway. If that sounds good to you, then go for it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #185.