Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve vulkan #56

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve vulkan #56

wants to merge 2 commits into from

Conversation

hypengw
Copy link
Contributor

@hypengw hypengw commented Feb 23, 2024

support modeling,interaction,topology with vulkan
require vulkan 1.2 and c++ 17

clouddon
clouddon requested changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@clouddon clouddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SortByKey algaorithm crashes, VkProgram also contains a lot of compilation issues

@hypengw
Copy link
Contributor Author

hypengw commented Mar 5, 2024

tested with Test_Core and Qt_Pickers.

@hypengw hypengw requested a review from clouddon March 6, 2024 02:30
@hypengw
Copy link
Contributor Author

hypengw commented Mar 14, 2024

@clouddon
Any plan to merge this?

clouddon
clouddon requested changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@clouddon clouddon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SortByKey still crashes when I test with App_GLPointVisualModule and App_GLSurfaceVisualModule

@hypengw
improve vulkan
d9c4128 
support modeling,interaction,topology with vulkan
require vulkan 1.2 and c++ 17
add vkcomp context
add vk descriptor cache
fix test
@hypengw
Copy link
Contributor Author

hypengw commented Mar 29, 2024

fix arr component
use common modeling files
add triangle merge func
add interaction mergeIndex func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clouddon clouddon clouddon requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hypengw @clouddon