Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement patch accept interface #35

Closed
ptgolden opened this issue Apr 20, 2015 · 6 comments
Closed

Implement patch accept interface #35

ptgolden opened this issue Apr 20, 2015 · 6 comments

Comments

@ptgolden
Copy link
Member

Users are now able to submit patches, but they cannot yet be accepted

@atomrab
Copy link

atomrab commented Apr 21, 2015

In both Chrome and Firefox, clicking the "Submit patch" button causes a spinning processing icon to appear at the top of the page, but nothing happens on the user side after that. When one clicks on "Submitted patches", nothing appears. Should there be some event on the user-interface side to show that something has happened?

We tested this by adding a period (Pre-Pottery Neolithic A) to an existing collection (King and Stager) in local idbs entitled "test1" in both cases (in case something shows up on the server side).

@atomrab
Copy link

atomrab commented Apr 21, 2015

UPDATE: when we added a NEW collection (the British Museum thesaurus) with one new period, the "Submit Patch" produced the image below. The screen now includes the new collection (period itself not specified), the new period we'd previously added to an existing collection, and two periods that are listed as "edited" from the same existing collection that we're quite sure we did not just edit. It would be helpful in this case to see either a timestamp for the edit or some sort of view of the edits that had been made (I think this would be generally helpful, actually, for people to keep track of their own edits before submission, even if the bug is fixed).

submit_patch_capture

@atomrab
Copy link

atomrab commented Apr 21, 2015

UPDATE: submission of that patch (select all for new period collections and new periods) went through when I was logged in with my ORCID; "Submitted Patches" led to a page with the following message:

https://test.perio.do/patches/1/
Resolved? false

@ptgolden
Copy link
Member Author

I'm going to create a new issue for things that don't have to do with accepting patches

@ptgolden
Copy link
Member Author

ptgolden commented Jun 4, 2015

Initial implementation in af1e5d4. Not deployed yet.

@ptgolden
Copy link
Member Author

ptgolden commented Jul 8, 2015

Patch acceptance is now implemented. If there are problems with anything, we should include them in a new, separate issue.

@ptgolden ptgolden closed this as completed Jul 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants