Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Test for case where we don't have access to a file
Test for case where we don't have access to a file. Quote from Dscho: > + } else { > + if (p->mod_dst) > + die(_("unexpected mode %d\n"), p->mod_dst); Hmm. This does not match what the shell script version does: *) # unexpected type eval_gettextln "unexpected mode \$mod_dst" >&2 continue ;; I think we should also just write the message to `stderr` and continue, not `die()`. In addition to that, I am missing the C code for this case: 000000) ;; # removed It is quite possible that our test suite does not cover this case (or did the test suite fail for you?). If that is indeed the case, it would be really good to add a test case as part of this patch series, to gain confidence in the correctness of the conversion. ============================================= Since we cover the case already, I have added a comment stating that we ignore in case of p->mod_dst=0000000.
- Loading branch information