Skip to content

Commit

Permalink
github actions: actions/setup-go@v3, remove golint
Browse files Browse the repository at this point in the history
golint has been deprecated since 2020.

Fix version lock to use go1.17. It is because gosec is still not
compatible with go1.18.
  • Loading branch information
maruel committed May 17, 2022
1 parent da8a12f commit c1c063a
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,9 @@ jobs:
runs-on: "${{matrix.os}}"
name: "go${{matrix.gover}}.x on ${{matrix.os}}"
steps:
- uses: actions/setup-go@v2
- uses: actions/setup-go@v3
with:
go-version: "^${{matrix.gover}}.0"
go-version: "~${{matrix.gover}}.0"

# Checkout and print debugging information.
- name: Turn off git core.autocrlf
Expand All @@ -56,7 +56,6 @@ jobs:
run: |
go install -v github.com/gordonklaus/ineffassign@latest
go install -v github.com/securego/gosec/cmd/gosec@latest
go install -v golang.org/x/lint/golint@latest
go install -v golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow@latest
go install -v honnef.co/go/tools/cmd/staticcheck@latest
- name: 'go install necessary tools (ubuntu)'
Expand All @@ -76,10 +75,6 @@ jobs:
SHADOW_TOOL="${SHADOW_TOOL}.exe"
fi
go vet -vettool=$SHADOW_TOOL ./...
- name: 'Check: golint'
if: always()
# TODO: Remove true if we make this check ever pass.
run: golint -set_exit_status ./... || true
- name: 'Check: inefficient variable assignment'
if: always()
run: ineffassign ./...
Expand Down

0 comments on commit c1c063a

Please sign in to comment.