Git commit fails on Windows 7/8.1 with TypeError: environment can only contain strings

[russgray]

I'm trying to use bumpversion on Windows, but I get an error when I try to autocommit with git. I believe the problem is in BaseVCS.commit with the following code:

subprocess.check_output(cls._COMMIT_COMMAND + [f.name], env=dict(
    list(os.environ.items()) + [('HGENCODING', 'utf-8')]
))

Dumping env from within subprocess.py gives the following output:

{

...

 'FRAMEWORKVERSION': 'v4.0.30319',
 'FRAMEWORKVERSION32': 'v4.0.30319',
 'FSHARPINSTALLDIR': 'C:\\Program Files (x86)\\Microsoft SDKs\\F#\\3.1\\Framework\\v4.0\\',
 u'HGENCODING': u'utf-8',
 'HOME': 'C:\\Users\\rgray',
 'HOMEPATH': '\\',

...

}

Note that HGENCODING seems to have been added to the dict as unicode. If I force it to ascii as follows then it works as expected:

subprocess.check_output(cls._COMMIT_COMMAND + [f.name], env=dict(
    list(os.environ.items()) + [('HGENCODING'.encode('ascii'), 'utf-8'.encode('ascii'))]
))

I will submit a pull request with this fix.

The stack trace:

Traceback (most recent call last):
  File "C:\Python27\Scripts\bumpversion-script.py", line 9, in <module>
    load_entry_point('bumpversion==0.5.0', 'console_scripts', 'bumpversion')()
  File "C:\Python27\lib\site-packages\bumpversion\__init__.py", line 965, in main
    vcs.commit(message=commit_message)
  File "C:\Python27\lib\site-packages\bumpversion\__init__.py", line 74, in commit
    list(os.environ.items()) + [('HGENCODING', 'utf-8')]
  File "C:\Python27\lib\subprocess.py", line 537, in check_output
    process = Popen(stdout=PIPE, *popenargs, **kwargs)
  File "C:\Python27\lib\subprocess.py", line 679, in __init__
    errread, errwrite)
  File "C:\Python27\lib\subprocess.py", line 896, in _execute_child
    startupinfo)
TypeError: environment can only contain strings

[peritus]

Fixed (for details see #64).

[Nurdok]

Seems like #64 wasn't actually merged and this also happens on Windows 10. Are there plans to implement Windows support soon?

[wooyek]

In my case on Windows 10 in Py 3.5 making additional env setting HGENCODING, a string worked around this issue:

    @classmethod
    def commit(cls, message):
        f = NamedTemporaryFile('wb', delete=False)
        f.write(message.encode('utf-8'))
        f.close()
        subprocess.check_output(cls._COMMIT_COMMAND + [f.name], env=dict(
            list(os.environ.items()) + [('HGENCODING', 'utf-8')]
        ))
        os.unlink(f.name)

[DancingQuanta]

I am still having issues when using Anaconda and cygwin with latest bumpversion.

[wooyek]

This project is stalled. Try to use bump2version instead.