Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better slow connection support #34

Closed
wants to merge 1 commit into from
Closed

Better slow connection support #34

wants to merge 1 commit into from

Conversation

HuwSy
Copy link

@HuwSy HuwSy commented Mar 2, 2021

Issue
Slow internet speeds and slow page loads prevent navigating to end correctly without resulting in many many navRight steps. Additionally impacts navLeft when this doesn’t load in a timely manner (or possibly portrait photos TBC)

Background
The page down/end detection done off screen shots when the unpopulated gray tiles match again and again doesn’t recognise its not reached the end.

Implementation
By waiting slightly longer between pagination it at least loads the gray boxes to correct proportions and identifies the page has not reached end. Also adding a nudge the window.resize() before attempting click left better tolerate slow page loads with large images or videos on slow connections.

Fix for issue #33 and possibly #19

More tolerance for slow connections when running page down/end detection by waiting slightly longer and nudge the page resize before attempting click left to better tolerate slow page loads with large images or videos on slow connections.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@HuwSy
Copy link
Author

HuwSy commented Mar 2, 2021

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@HuwSy HuwSy closed this by deleting the head repository Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants