Uncaught SyntaxError: Unexpected token )

[elimisteve]

Whether I use the 0.10 release or git clone master, I get errors like this in the DOM:

Uncaught SyntaxError: Unexpected token )
index.js:641 Creating new search session for query ""
index.js:244 Uncaught TypeError: Cannot read property 'getAspect' of undefined
    at Object.getAspects_ (index.js:244)
    at Object.render (index.js:178)
    at p._renderValidatedComponentWithoutOwnerOrContext (react-dom.min.js:11)
    at p._renderValidatedComponent (react-dom.min.js:11)
    at performInitialMount (react-dom.min.js:11)
    at p.mountComponent (react-dom.min.js:11)
    at Object.mountComponent (react-dom.min.js:12)
    at performInitialMount (react-dom.min.js:11)
    at p.mountComponent (react-dom.min.js:11)
    at Object.mountComponent (react-dom.min.js:12)
    at i (react-dom.min.js:12)
    at r.perform (react-dom.min.js:13)
    at s (react-dom.min.js:12)
    at r.perform (react-dom.min.js:13)
    at Object.batchedUpdates (react-dom.min.js:12)
    at Object.a [as batchedUpdates] (react-dom.min.js:12)
    at Object._renderNewRootComponent (react-dom.min.js:12)
    at Object._renderSubtreeIntoContainer (react-dom.min.js:12)
    at Object.render (react-dom.min.js:12)
    at render (perkeep.privte.ch/:109)
    at perkeep.privte.ch/:113
react-dom.min.js:11 Uncaught TypeError: Cannot read property '_currentElement' of null
    at p._updateRenderedComponent (react-dom.min.js:11)
    at p._performComponentUpdate (react-dom.min.js:11)
    at p.updateComponent (react-dom.min.js:11)
    at performUpdateIfNecessary (react-dom.min.js:11)
    at Object.performUpdateIfNecessary (react-dom.min.js:12)
    at s (react-dom.min.js:12)
    at r.perform (react-dom.min.js:13)
    at o.perform (react-dom.min.js:13)
    at o.perform (react-dom.min.js:12)
    at Object.k [as flushBatchedUpdates] (react-dom.min.js:12)
    at r.closeAll (react-dom.min.js:13)
    at r.perform (react-dom.min.js:13)
    at Object.batchedUpdates (react-dom.min.js:12)
    at Object.u [as enqueueUpdate] (react-dom.min.js:12)
    at r (react-dom.min.js:12)
    at Object.enqueueForceUpdate (react-dom.min.js:12)
    at Object.r.forceUpdate (react-with-addons.min.js:10)
    at Object.<anonymous> (index.js:644)
    at cam.SearchSession.goog.events.EventTarget.fireListeners (eventtarget.js:284)
    at Function.goog.events.EventTarget.dispatchEventInternal_ (eventtarget.js:381)
    at cam.SearchSession.goog.events.EventTarget.dispatchEvent (eventtarget.js:196)
    at cam.SearchSession.searchDone_ (search_session.js:284)
    at cam.ServerConnection.handleXhrResponseJson_ (server_connection.js:161)
    at goog.net.XhrIo.goog.events.EventTarget.fireListeners (eventtarget.js:284)
    at Function.goog.events.EventTarget.dispatchEventInternal_ (eventtarget.js:381)
    at goog.net.XhrIo.goog.events.EventTarget.dispatchEvent (eventtarget.js:196)
    at goog.net.XhrIo.onReadyStateChangeHelper_ (xhrio.js:868)
    at goog.net.XhrIo.onReadyStateChangeEntryPoint_ (xhrio.js:814)
    at goog.net.XhrIo.onReadyStateChange_ (xhrio.js:798)

Any idea what the problem is? Thanks.

[elimisteve]

Perhaps the trailing comma on line 149 is giving Chromium grief?...

[mpl]

@elimisteve hey. I cannot reproduce. Can you give more detail please?
Like, the browser you're using. And what were the circumstances? what were you trying to do in the web UI?

[elimisteve]

I get this error when visiting /ui in Chromium 57 on Linux (Debian 8.7), but there's no error on Firefox 60 nor Chrome 70 (all on Linux).

[mpl]

How old is chromium 57? (i.e. is this error actually worth spending time on?)

[elimisteve]

https://en.wikipedia.org/wiki/Google_Chrome_version_history says 2017-03-09 -- 21 months ago.

Chromium 57 is the default on Debian 8.7. If I need to use Firefox to use the Perkeep UI, then it's not the end of the world :-) ; sounds like an issue with the build system only building for newer browsers?

[mpl]

Hmm given that Jessie is supported until 2020, we should support it.
However, can you not install a newer chrome through the official google repo, instead of the debian one (i.e. deb [arch=amd64] http://dl.google.com/linux/chrome/deb/ stable main)?
it's what i do on my ancient ubuntu (trusty), which allows me to run Chrome 67 without any problem.

I have not looked into it, but fwiw, I think the issue is that a js or dom feature is not supported on your older chrome, rather than a build problem.

[adrm]

It seems that this issue can be closed right now based on comments here :)

[elimisteve]

@adrm Fine by me 👍 Closing.