Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note: site_perl could mess with the bundled tree #60

Closed
miyagawa opened this issue Jan 22, 2013 · 1 comment
Closed

Note: site_perl could mess with the bundled tree #60

miyagawa opened this issue Jan 22, 2013 · 1 comment

Comments

@miyagawa
Copy link
Contributor

because carton internally uses cpanm's -L which could in theory create a non-deterministic tree depending on what you have in site_perl in the local machine, bundle exec on the other machine might fail if one of the modules bundled have an implicit dependency to the modules that happen to be in site_perl.

This is rare, but could happen, and running carton exec, because it uses lib::core::only, would blow up. Turning off lib::core::only might be efficient in such cases, but it will just hide the problem than actually fixing it.

miyagawa added a commit that referenced this issue Jun 2, 2013
…PERL5LIB. Re: #82 #70 #60

PERL5LIB isn't perfect since it doesn't eliminate site_perl from @inc
in the child process, which means carton exec could accidentally load
modules from site_perl even when they are not available in the
carton.lock.

We'll address this by either implementing a check-like logic in the
exec (which would add an overhead), or add some additional @inc hooks
in the development, which can detect such errors, a la App::FatPacker
@miyagawa
Copy link
Contributor Author

miyagawa commented Jun 2, 2013

closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant