updates/fixes for next release #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* use explicitely imported HTTP_... constants instead of the old RC_... ones * change error for illegal methods to HTTP_NOT_IMPLEMENTED, which according to the HTTP specs is the correct one * allow HEAD method in addition to GET
Allow schemes 'ldaps' and 'ldapi' in addition to the pure 'ldap'. To support the scheme 'ldapi', add LWP/Protocol/ldapi.pm
Re-factor a bit to accept extension 'x-tls' and to call Net::LDAP->start_tls() if it was given.
If user is not given using $uri->userinfo, try to get it from the Authorization HTTP header. Currently only Basic authorization is supported.
* create objects consistently using 'CLASS->new(args)' instead of 'new CLASS args' * indent method parameters for cleaner reading * add comments * harmonize coding style * catch errors in Net::LDAP->new() * fix calls of $ldap->code / $ldap->error to $mesg->code / $mesg->error
A small sample application to show the usage of LWP::Protocol::LDAP.
Do not return $self->{asn}{cookie} which is never set anwhere.
Instead return $self->{asn}{newcookie}.
Based on a patch sent by Howard Wilkinson <howard@orb-it.net>:
Date: 20.06.2012 13:06
From: Howard Wilkinson <howard@orb-it.net>
To: gbarr <gbarr@pobox.com>
Reply to: howard@cohtech.com
Graham,
[...]
Also, the following patch is needed to fix a warning which points at a
bug.
--- LDAP/Intermediate/SyncInfo.pm~ 2012-01-29 09:31:37.000000000 +0000
+++ LDAP/Intermediate/SyncInfo.pm 2012-06-20 12:00:27.000000000 +0100
@@ -56,9 +56,9 @@
sub newcookie {
my $self = shift;
- @_ ? ($self->{asn}{newcookie}=shift)
- : $self->{asn}{newcookie};
- $self->{asn}{cookie};
+ return (@_
+ ? ($self->{asn}{newcookie}=shift)
+ : $self->{asn}{newcookie});
}
sub responseValue {
Howard.
marschap
added a commit
that referenced
this pull request
Sep 16, 2012
updates/fixes for next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.