preparation for the next release #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to Carsten Dumke <Carsten.Dumke@gmx.net> for reporting it.
Although not required by the RFC, Base64-encode those values that end in spaces when writing LDIFs. This makes it easier for the user to visually detect those values and increases compatibility with other implementations (e.g. OpenLDAP's ldapsearch).
LDIF change records may contain 'control:' stanzas. Instead of chocking on them when reading, decode them properly. In this commit, the controls read are not returned to the caller, they are only parsed in Net::LDAP::LDIF internally and ignored. This is done in order to leave the API unchanged.
When operating on the standard IO handles, treat mode 'a'/'>>' (append) the same way as mode 'w'/'>' (write) instead of 'r'/'<' (read). Allow using the "translated" mode codes too: '<', '>', and '>>'. Use 3-parameter open when possible. Rearrange the code slightly to make it more readable.
marschap
added a commit
that referenced
this pull request
Mar 29, 2013
preparation for the next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.