add -r option for reverse hierarchical sort on changetype: delete ent… #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transitivity is not preserved if only filtering on delete. Therefore first order on add, delete and modify and then filter on delete for reversal of order.
|
I added some changes to fix the reverse ordering option: It failed, when add, delete and modify operations were present in the file at the same time. Now all operations are first sorted by add, delete, modify, then within those add is supported along the tree towards the children (same for modify), and delete is sorted from children to root if -r is speficied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ries
When exporting the current server state as an ldif and having the new state as ldif, ldifdiff prints out a possibly non-hierarchical sorted ldif file which is not usable by ldapmodify. ldifsort sorts all the dns with the -h option correctly, but in the case of delete entries the modification ldif has to be sorted inversely for correctly reflecting the changes.