Add utility functions for converting Microsoft FILETIMEs to UNIX timestamps #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oh cool, we don't need these awful things
|
@rc4 this looks great. Could we get it merged please, I've just come looking and digging for the same thing... Presumably it should have some tests too ideally? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've recently been doing a fair amount of work with Active Directory using Net::LDAP, and have found myself needing to convert Microsoft's FILETIME timestamp formats to something more useful in many of my scripts. Microsoft uses this format for a number of attributes, including lastLogon/lastLogonTimeStamp, pwdLastSet, accountExpires, and more.
I figured these made sense to also have alongside the functions for converting between generalizedTimes (which I'm pretty sure AD also uses, for some things...) and UNIX timestamps for anyone else that uses this module to interface with AD.
I've kept the functions pretty simple for now to offer more flexibility, but if you think it would be better for me to be more strict with the input/output validation (or offer more functionality?), I'm willing to add that.